Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: codeflare component #1387

Merged
merged 14 commits into from
Nov 28, 2024
Merged

feat: codeflare component #1387

merged 14 commits into from
Nov 28, 2024

Conversation

biswassri
Copy link
Contributor

@biswassri biswassri commented Nov 20, 2024 •
edited
Loading

JIRA: https://issues.redhat.com/browse/RHOAIENG-13181

Description

Refactoring codeflare component

How Has This Been Tested?

Deploy changes to a cluster with component

codeflare:
      managementState: Removed

Update

codeflare:
      managementState: Managed

in the DSC
A new CF instance is created and marked Ready

Screenshot or short clip

image

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 20, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from biswassri. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov Codecov
Copy link

codecov bot commented Nov 20, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (feature-operator-refactor@7384fe6). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...atasciencecluster/datasciencecluster_controller.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@                     Coverage Diff                      @@
##             feature-operator-refactor    #1387   +/-   ##
============================================================
  Coverage                             ?   27.15%           
============================================================
  Files                                ?       60           
  Lines                                ?     4805           
  Branches                             ?        0           
============================================================
  Hits                                 ?     1305           
  Misses                               ?     3348           
  Partials                             ?      152

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@biswassri biswassri changed the title [WIP] refactor: codeflare component refactor: codeflare component Nov 22, 2024
@biswassri biswassri changed the title refactor: codeflare component feat: codeflare component Nov 22, 2024
@biswassri
Copy link
Contributor Author

/cc @lburgazzoli

@openshift-ci openshift-ci bot requested a review from lburgazzoli November 22, 2024 15:18
@biswassri
Copy link
Contributor Author

/cc @zdtsw

@openshift-ci openshift-ci bot requested a review from zdtsw November 25, 2024 14:14
@biswassri biswassri mentioned this pull request Nov 25, 2024
Merged
5 tasks
grdryn
grdryn reviewed Nov 26, 2024
View reviewed changes
Copy link
Member

@grdryn grdryn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to me, with some optional suggestions inline below.

controllers/components/codeflare/codeflare.go Show resolved Hide resolved
controllers/components/codeflare/codeflare.go Show resolved Hide resolved
tests/e2e/codeflare_test.go Outdated Show resolved Hide resolved
controllers/components/codeflare/codeflare_controller.go Outdated Show resolved Hide resolved
grdryn
grdryn reviewed Nov 27, 2024
View reviewed changes
Copy link
Member

@grdryn grdryn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 27, 2024
@openshift-ci openshift-ci bot removed the lgtm label Nov 27, 2024
@lburgazzoli
Copy link
Contributor

@biswassri I think you need yet another rebase to alisgn with:

zdtsw
zdtsw reviewed Nov 27, 2024
View reviewed changes
Copy link
Member

@zdtsw zdtsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these two need fix

controllers/components/codeflare/codeflare_controller.go Outdated Show resolved Hide resolved
controllers/components/codeflare/codeflare_controller.go Outdated Show resolved Hide resolved
@biswassri
Copy link
Contributor Author

/test opendatahub-operator-e2e

zdtsw
zdtsw reviewed Nov 28, 2024
View reviewed changes
Copy link
Member

@zdtsw zdtsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lburgazzoli
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 28, 2024
@zdtsw zdtsw merged commit 8e9be7b into opendatahub-io:feature-operator-refactor Nov 28, 2024
9 of 10 checks passed
@zdtsw zdtsw mentioned this pull request Nov 28, 2024
Merged
5 tasks
This was referenced Dec 8, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ykaliuta ykaliuta ykaliuta left review comments

@lburgazzoli lburgazzoli lburgazzoli left review comments

@zdtsw zdtsw zdtsw left review comments

@grdryn grdryn grdryn left review comments

@VaishnaviHire VaishnaviHire Awaiting requested review from VaishnaviHire

Assignees

@grdryn grdryn

@lburgazzoli lburgazzoli

Labels
feature-operator-refactor lgtm odh-2.22
Projects
ODH Platform Planning
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@biswassri @lburgazzoli @grdryn @zdtsw @ykaliuta @VaishnaviHire @openshift-merge-robot