Implement garbage collection action #1374

lburgazzoli · 2024-11-15T15:48:47Z

Signed-off-by: Luca Burgazzoli lburgazzoli@gmail.com

Description

https://issues.redhat.com/browse/RHOAIENG-15183

How Has This Been Tested?

Screenshot or short clip

Merge criteria

You have read the contributors guide.
Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
~~Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).~~
The developer has manually tested the changes and verified that the changes work

codecov · 2024-11-15T17:12:13Z

Codecov Report

Attention: Patch coverage is 29.42779% with 259 lines in your changes missing coverage. Please review.

Please upload report for BASE (feature-operator-refactor@74b3e85). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
pkg/services/gc/gc.go	0.00%	204 Missing ⚠️
pkg/controller/actions/gc/action_gc.go	70.51%	18 Missing and 5 partials ⚠️
pkg/services/gc/gc_support.go	34.28%	23 Missing ⚠️
pkg/controller/actions/gc/action_gc_support.go	72.72%	4 Missing and 2 partials ⚠️
pkg/controller/actions/deploy/action_deploy.go	76.92%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@                     Coverage Diff                      @@
##             feature-operator-refactor    #1374   +/-   ##
============================================================
  Coverage                             ?   26.85%           
============================================================
  Files                                ?       60           
  Lines                                ?     4782           
  Branches                             ?        0           
============================================================
  Hits                                 ?     1284           
  Misses                               ?     3349           
  Partials                             ?      149

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests

pkg/controller/actions/render/kustomize/action_render_manifests.go

pkg/services/gc/gc.go

VaishnaviHire · 2024-11-15T22:48:21Z

pkg/services/gc/gc.go

+)
+
+// TODO: this singleton must be removed.
+var Instance *GC


Can this eventually be a struct?

it is actually a struct, I've removed the global Run method and added some better comments

main.go

pkg/services/gc/gc.go

main.go

controllers/components/dashboard/dashboard_controller.go

controllers/components/datasciencepipelines/datasciencepipelines_controller.go

zdtsw · 2024-11-20T15:08:24Z

pkg/controller/actions/gc/action_gc.go

+	if !rr.Generated {
+		return nil
+	}


so this is saying:
even component CR gets deleted by human, after it gets recreated, since we have cache, rr.Generated = true wont be called, thus this run() will get fast return nil

Not sure if I got it right, but in the case of the component CR being re-created, the rr.Generated == true, because the rendering task takes into account also the CR's UID when computing the hash, so the gc task would kicks in.

pkg/controller/actions/render/render_support.go

pkg/services/gc/gc_support.go

Signed-off-by: Luca Burgazzoli <lburgazzoli@gmail.com>

openshift-ci · 2024-11-21T08:42:01Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zdtsw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [zdtsw]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci bot requested review from CFSNM and lphiri November 15, 2024 15:48

VaishnaviHire reviewed Nov 15, 2024

View reviewed changes

pkg/controller/actions/render/kustomize/action_render_manifests.go Outdated Show resolved Hide resolved

VaishnaviHire reviewed Nov 15, 2024

View reviewed changes

pkg/services/gc/gc.go Outdated Show resolved Hide resolved

VaishnaviHire reviewed Nov 15, 2024

View reviewed changes

main.go Show resolved Hide resolved

lburgazzoli force-pushed the RHOAIENG-15183-gc branch from 629bcba to 12d0afb Compare November 17, 2024 11:52

lburgazzoli requested a review from VaishnaviHire November 17, 2024 11:53

zdtsw reviewed Nov 18, 2024

View reviewed changes

pkg/services/gc/gc.go Show resolved Hide resolved

main.go Show resolved Hide resolved

controllers/components/dashboard/dashboard_controller.go Show resolved Hide resolved

lburgazzoli force-pushed the RHOAIENG-15183-gc branch from 85f2c44 to 603652a Compare November 18, 2024 11:59

lburgazzoli added the feature-operator-refactor label Nov 19, 2024

lburgazzoli force-pushed the RHOAIENG-15183-gc branch 2 times, most recently from 3f6dda1 to eb3b863 Compare November 20, 2024 11:08

lburgazzoli requested review from zdtsw and removed request for lphiri and CFSNM November 20, 2024 11:09

zdtsw reviewed Nov 20, 2024

View reviewed changes

controllers/components/datasciencepipelines/datasciencepipelines_controller.go Outdated Show resolved Hide resolved

lburgazzoli force-pushed the RHOAIENG-15183-gc branch from eb3b863 to f00710e Compare November 20, 2024 15:06

zdtsw reviewed Nov 20, 2024

View reviewed changes

lburgazzoli force-pushed the RHOAIENG-15183-gc branch from e71521b to ba512a7 Compare November 20, 2024 19:29

lburgazzoli requested a review from zdtsw November 20, 2024 20:49

lburgazzoli force-pushed the RHOAIENG-15183-gc branch from ba512a7 to a6260ae Compare November 20, 2024 23:09

Implement garbage collection action

dcfd87a

Signed-off-by: Luca Burgazzoli <lburgazzoli@gmail.com>

lburgazzoli force-pushed the RHOAIENG-15183-gc branch from a6260ae to dcfd87a Compare November 20, 2024 23:11

zdtsw approved these changes Nov 21, 2024

View reviewed changes

openshift-ci bot assigned zdtsw Nov 21, 2024

openshift-ci bot added the lgtm label Nov 21, 2024

zdtsw approved these changes Nov 21, 2024

View reviewed changes

openshift-ci bot added the approved label Nov 21, 2024

openshift-merge-bot bot merged commit d748e02 into opendatahub-io:feature-operator-refactor Nov 21, 2024
10 checks passed

lburgazzoli deleted the RHOAIENG-15183-gc branch November 21, 2024 08:47

This was referenced Dec 8, 2024

A reconciler should not require the DSCI to perform cleanup action to avoid deadlock #1428

Closed

Refactor DSC controller #1430

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement garbage collection action #1374

Implement garbage collection action #1374

lburgazzoli commented Nov 15, 2024 •

edited

Loading

codecov bot commented Nov 15, 2024 •

edited

Loading

VaishnaviHire Nov 15, 2024

lburgazzoli Nov 16, 2024

zdtsw Nov 20, 2024

lburgazzoli Nov 20, 2024 •

edited

Loading

openshift-ci bot commented Nov 21, 2024

Implement garbage collection action #1374

Implement garbage collection action #1374

Conversation

lburgazzoli commented Nov 15, 2024 • edited Loading

Description

How Has This Been Tested?

Screenshot or short clip

Merge criteria

codecov bot commented Nov 15, 2024 • edited Loading

Codecov Report

VaishnaviHire Nov 15, 2024

Choose a reason for hiding this comment

lburgazzoli Nov 16, 2024

Choose a reason for hiding this comment

zdtsw Nov 20, 2024

Choose a reason for hiding this comment

lburgazzoli Nov 20, 2024 • edited Loading

Choose a reason for hiding this comment

openshift-ci bot commented Nov 21, 2024

lburgazzoli commented Nov 15, 2024 •

edited

Loading

codecov bot commented Nov 15, 2024 •

edited

Loading

lburgazzoli Nov 20, 2024 •

edited

Loading