Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing rbac on dashbaord component to start Operator from CSV #1314

Conversation

zdtsw
Copy link
Member

@zdtsw zdtsw commented Oct 24, 2024

Description

  • builder marker only work with type struct definition either we move all these back to the rbac file with DSC or add into API for each => up for decide later

How Has This Been Tested?

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@zdtsw zdtsw requested a review from VaishnaviHire October 24, 2024 09:17
@zdtsw zdtsw requested review from lburgazzoli and removed request for adelton and ajaypratap003 October 24, 2024 09:17
- builder marker only work with type struct definition
  either we move all these back to the rbac file with DSC or add into API for each

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
@zdtsw zdtsw force-pushed the chore_fix_permission branch from a588f81 to a092c6e Compare October 24, 2024 09:25
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (feature-operator-refactor@6db3f70). Learn more about missing BASE report.

Additional details and impacted files
@@                     Coverage Diff                      @@
##             feature-operator-refactor    #1314   +/-   ##
============================================================
  Coverage                             ?   19.98%           
============================================================
  Files                                ?       32           
  Lines                                ?     3438           
  Branches                             ?        0           
============================================================
  Hits                                 ?      687           
  Misses                               ?     2684           
  Partials                             ?       67           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

openshift-ci bot commented Oct 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lburgazzoli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit a41e5cf into opendatahub-io:feature-operator-refactor Oct 24, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants