Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initialize Internal APIs for components #1304
Initialize Internal APIs for components #1304
Changes from 29 commits
a717823
157e0f3
590777d
c88a428
cfb2297
487dbe8
a812a26
b438f3a
a54e58b
dc67181
ba56369
aa0ea69
a364358
0f2ad33
645ccf6
102881e
23da2f9
0eedf2c
2c5901c
c00dcce
2b4880c
d0fe61f
bef2ef9
03fbbd4
d3c1ccc
5fea836
52d8e4a
e9f8d67
59edbbf
04e1ccd
8baa3e5
5016936
72d34b2
a3a1273
d81e733
c005b6e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this might be slightly preferred? I don't know what the implications of one over the other are though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure either. I defined the crd
Kserve
to be consistent with current component spec https://github.com/opendatahub-io/opendatahub-operator/blob/incubation/apis/datasciencecluster/v1/datasciencecluster_types.go#L68There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i dont see it is a big problem, we are using Kserve in most of the places from Operator, even the current DSC.components.