Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: centralize manifest overriding #1227

Closed
wants to merge 3 commits into from
Closed

RFC: centralize manifest overriding #1227

wants to merge 3 commits into from

Conversation

ykaliuta
Copy link
Contributor

@ykaliuta ykaliuta commented Sep 9, 2024

The idea is to move manifest configuration in one place and separate overriding from default manifests.
It will allow later move image overriding for default only manifest to the init stage.
With this logic the manifest are overridden for both enable and not-enabled case. Is it ok?
Still open question about cleanup after changing simultaneously enabled and DevFlags values.

Description

How Has This Been Tested?

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@ykaliuta
component: remove OverrideManifests() from ComponentInterface
8bf687f 
OverrideManifests() is by the matter of fact an internal method
called only from Reconcile() but not by any component external code.

Removing it from the interface gives per component flexibility in
implementation of the functionality.

Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com>
@ykaliuta
component: add IsManifestsOverridden method
b4c597a 
Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com>
@ykaliuta
workbenches: convert path configuration to a structure
9912b7f 
Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com>
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 9, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 9, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from ykaliuta. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ykaliuta
Copy link
Contributor Author

ykaliuta commented Sep 9, 2024

/cc @zdtsw

@openshift-ci openshift-ci bot requested a review from zdtsw September 9, 2024 17:21
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ykaliuta
Copy link
Contributor Author

Let's address this as a part of global rewriting with #1304

@ykaliuta ykaliuta closed this Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zdtsw zdtsw Awaiting requested review from zdtsw

Assignees
No one assigned
Labels
do-not-merge/work-in-progress needs-rebase
Projects
ODH Platform Planning
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ykaliuta @openshift-merge-robot