Skip to content

Commit

Permalink
update: prepare feast to be enabled
Browse files Browse the repository at this point in the history
- revert back d67f240e to test feast in e2e
- set feast by default managed component

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
  • Loading branch information
zdtsw committed Feb 27, 2025
1 parent 73d70b8 commit 92dad5e
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ metadata:
"managementState": "Managed"
},
"feastoperator": {
"managementState": "Removed"
"managementState": "Managed"
},
"kserve": {
"managementState": "Managed",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,4 +50,4 @@ spec:
managementState: "Managed"
registriesNamespace: "odh-model-registries"
feastoperator:
managementState: "Removed"
managementState: "Managed"
2 changes: 1 addition & 1 deletion pkg/upgrade/upgrade.go
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ func CreateDefaultDSC(ctx context.Context, cli client.Client) error {
ManagementSpec: common.ManagementSpec{ManagementState: operatorv1.Managed},
},
FeastOperator: componentApi.DSCFeastOperator{
ManagementSpec: common.ManagementSpec{ManagementState: operatorv1.Removed},
ManagementSpec: common.ManagementSpec{ManagementState: operatorv1.Managed},

Check warning on line 97 in pkg/upgrade/upgrade.go

View check run for this annotation

Codecov / codecov/patch

pkg/upgrade/upgrade.go#L97

Added line #L97 was not covered by tests
},
},
},
Expand Down
4 changes: 1 addition & 3 deletions tests/e2e/controller_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,7 @@ var (
componentApi.KserveComponentName: kserveTestSuite,
componentApi.ModelMeshServingComponentName: modelMeshServingTestSuite,
componentApi.ModelControllerComponentName: modelControllerTestSuite,
// Temporary disable Feast until images are moved from docker.io
// TODO: enable when ready
// componentApi.FeastOperatorComponentName: feastOperatorTestSuite,
componentApi.FeastOperatorComponentName: feastOperatorTestSuite,
},
},
services: TestGroup{
Expand Down
2 changes: 1 addition & 1 deletion tests/e2e/feastoperator_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import (
)

// TODO: remove unused when test enabled back.
func feastOperatorTestSuite(t *testing.T) { //nolint:unused
func feastOperatorTestSuite(t *testing.T) {
t.Helper()

ct, err := NewComponentTestCtx(&componentApi.FeastOperator{})
Expand Down

0 comments on commit 92dad5e

Please sign in to comment.