ENG-11059: Adds section about Kueue alerts #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChughShilpa
reviewed
Sep 12, 2024
ChughShilpa
reviewed
Sep 12, 2024
|
Nice work Breda !! |
bredamc
commented
Sep 12, 2024
There was a problem hiding this comment.
@ChughShilpa I think the current text is fine as is, please see my replies to your comments and let me know if you agree?
Yes am fine with the text, it makes more sense. |
ChughShilpa
approved these changes
Sep 12, 2024
eturner24
requested changes
Sep 12, 2024
bredamc
force-pushed
the
ENG-11059_kueue_alerts
branch
from
f54ee65
to
74952e5
Compare
|
@eturner24 Thank you (as always!) for your great feedback! Please review the latest updates and let me know if you're happy to approve now? |
|
@sutaakar Can you please approve the changes added in the latest commit? |
…ring training jobs
bredamc
force-pushed
the
ENG-11059_kueue_alerts
branch
from
2ce9eea
to
4dbb3e2
Compare
|
@bredamc commit change looks good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ENG-11059: Adds section about Kueue alerts