Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

9737: Updating cert content for workbenches #442

Merged
merged 2 commits into from
Sep 6, 2024
Merged

9737: Updating cert content for workbenches #442

merged 2 commits into from
Sep 6, 2024

Conversation

grainnejenningsRH
Copy link
Contributor

Updates the current note in the docs on self-signed certs with existing workbenches. Adds an example of where users might need to manually provide the cert path for a package.

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

jstourac
jstourac approved these changes Sep 6, 2024
View reviewed changes
Copy link
Member

@jstourac jstourac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@grainnejenningsRH grainnejenningsRH merged commit d65891e into opendatahub-io:main Sep 6, 2024
@grainnejenningsRH grainnejenningsRH deleted the 9737workbenchCertsUpdate branch September 6, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstourac jstourac jstourac approved these changes

@chtyler chtyler chtyler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grainnejenningsRH @jstourac @chtyler