ENG-11839: Updates the download instructions for the demo notebooks #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bredamc
force-pushed
the
ENG-11839_dw_token
branch
2 times, most recently
from
59c5791
to
ad91aab
Compare
eturner24
reviewed
Sep 10, 2024
modules/downloading-the-demo-notebooks-from-the-codeflare-sdk.adoc
Outdated
Show resolved
Hide resolved
modules/running-distributed-data-science-workloads-from-notebooks.adoc
Outdated
Show resolved
Hide resolved
modules/running-distributed-data-science-workloads-from-notebooks.adoc
Outdated
Show resolved
Hide resolved
modules/running-distributed-data-science-workloads-from-notebooks.adoc
Outdated
Show resolved
Hide resolved
…, adds note about AMD64 image, clarifies Kueue is now optional, other minor updates
…prereqs; reinserts Kueue prereqs in notebook section to keep Kueue updates in separate PR
…fy a default local queue
bredamc
force-pushed
the
ENG-11839_dw_token
branch
from
48562a6
to
2bf6613
Compare
|
@eturner24 Many thanks for your great review comments! I've updated the text accordingly (albeit not always exactly as you suggested!). Would you like to review again, or are you happy for me to merge now? |
eturner24
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ENG-11839: Updates the download instructions for the demo notebooks