Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RHOAI-9817 TrustyAI data drift #408

Merged
merged 7 commits into from
Aug 14, 2024
Merged

RHOAI-9817 TrustyAI data drift #408

merged 7 commits into from
Aug 14, 2024

Conversation

aduquett
Copy link
Contributor

Adding upstream docs for monitoring data drift with TrustyAI and more reorganization.

chtyler
chtyler reviewed Aug 13, 2024
View reviewed changes
assemblies/configuring-trustyai.adoc

[role='_abstract']

To set up model monitoring for data scientists to use in {productname-short}, a cluster administrator does the following tasks:
To configure model monitoring with TrustyAI for data scientists to use in {productname-short}, a cluster administrator does the following tasks:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this module is aimed at cluster administrators, could we not use "you" instead of "cluster administrator"?

..."you must complete the following tasks".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree this sounds strange, but I wanted to make it clear this section was for admins until we separate the books.

chtyler
chtyler reviewed Aug 13, 2024
View reviewed changes
assemblies/setting-up-trustyai-for-your-project.adoc

[role='_abstract']

To set up model monitoring with TrustyAI for a data science project, a data scientist does the following tasks:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same kind of comment as before, if this is aimed at data scientists, should we not use "you"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree this sounds strange, but I wanted to make it obvious this section was for non-admins until we separate the books.

chtyler
chtyler requested changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@chtyler chtyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good, just a few minor changes requested.

chtyler
chtyler requested changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@chtyler chtyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more minor changes requested.

@aduquett aduquett requested review from chtyler and removed request for chtyler August 14, 2024 17:51
@aduquett aduquett merged commit 6053187 into opendatahub-io:main Aug 14, 2024
@aduquett aduquett deleted the RHOAI-9817_datadrift branch August 26, 2024 20:58
BSynRedhat pushed a commit to BSynRedhat/opendatahub-documentation that referenced this pull request Aug 28, 2024
@aduquett @BSynRedhat
RHOAI-9817 TrustyAI data drift (opendatahub-io#408)
f7aca51 
* RHOAI-9817 TrustyAI data drift

* peer review edits

* peer review edits

* incorporating QE review and adding metric definitions

* updates to definitions

* peer review round 2

* peer review round 2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chtyler chtyler chtyler requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aduquett @chtyler