Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENG-10357: Updates to add LoRA tuning #403

Merged
merged 9 commits into from
Sep 11, 2024
Merged

ENG-10357: Updates to add LoRA tuning #403

merged 9 commits into from
Sep 11, 2024

Conversation

bredamc
Copy link
Contributor

@bredamc bredamc commented Aug 12, 2024

ENG-10357: Updates to add LoRA tuning

@bredamc bredamc self-assigned this Aug 12, 2024
@bredamc bredamc marked this pull request as draft August 13, 2024 20:26
VanillaSpoon
VanillaSpoon reviewed Aug 14, 2024
View reviewed changes
Copy link

@VanillaSpoon VanillaSpoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @bredamc, Looks great!

modules/configuring-the-lora-training-job.adoc Outdated Show resolved Hide resolved
chtyler
chtyler requested changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@chtyler chtyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor changes requested.

@bredamc bredamc marked this pull request as ready for review September 11, 2024 13:30
@bredamc bredamc merged commit 7af334b into opendatahub-io:main Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sutaakar sutaakar sutaakar left review comments

@VanillaSpoon VanillaSpoon VanillaSpoon left review comments

@chtyler chtyler chtyler requested changes

Assignees

@bredamc bredamc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bredamc @sutaakar @VanillaSpoon @chtyler