Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

9179 Refactoring accelerator content #395

Conversation

grainnejenningsRH
Copy link
Contributor

@grainnejenningsRH grainnejenningsRH commented Aug 7, 2024

  • Updates the Working with accelerators title to reorganise and surface partner content, and include the Enabling NVIDIA GPUs steps (previously only included under Managing resources.
  • Updates the title of the NVIDIA GPU enablement content to explicitly mention NVIDIA, and updates titles/links/include statements that used the originals.
  • Adds notes specifying that only NVIDIA GPUs are supported as accelerators for model serving.
  • Cuts some duplicate accelerator profile content from the Intel Gaudi integration module.
  • Adds a file and a commented-out include statement for later updates.

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link
Contributor

@chtyler chtyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, but I think we capitalize "Operators"?

@grainnejenningsRH grainnejenningsRH merged commit 481a317 into opendatahub-io:main Aug 8, 2024
@grainnejenningsRH grainnejenningsRH deleted the 9179acceleratorRefactor branch August 8, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants