ENG-9443 Tuning a model by using the Training Operator #357
Conversation
bredamc
force-pushed
the
ENG-9443_tuning_operator
branch
from
de7ab7e
to
59f29c6
Compare
modules/configuring-the-training-operator-permissions-without-kueue.adoc
Outdated
Show resolved
Hide resolved
bredamc
force-pushed
the
ENG-9443_tuning_operator
branch
from
59f29c6
to
3178b9f
Compare
|
@VanillaSpoon Thank you for your comments, ready for you to review again and approve if you're happy :) |
There was a problem hiding this comment.
@bredamc I have suggested some formatting changes which are optional. I do recommend that you make steps instead of statements when the user must replace parameter values.
The other important comments are where you need to update links based on the change to the Working on data science projects guide
Please let me know if you have any questions
modules/configuring-the-training-operator-permissions-without-kueue.adoc
Outdated
Show resolved
Hide resolved
modules/configuring-the-training-operator-permissions-without-kueue.adoc
Outdated
Show resolved
Hide resolved
modules/configuring-the-training-operator-permissions-without-kueue.adoc
Outdated
Show resolved
Hide resolved
modules/configuring-the-training-operator-permissions-without-kueue.adoc
Outdated
Show resolved
Hide resolved
modules/configuring-the-training-operator-permissions-without-kueue.adoc
Outdated
Show resolved
Hide resolved
|
@MelissaFlinn Thank you so much for your great suggestions. I've implemented all of them now (I hope!), please review to ensure that I interpreted your suggestions correctly :) |
bredamc
force-pushed
the
ENG-9443_tuning_operator
branch
from
4662f95
to
5459498
Compare
modules/configuring-the-training-operator-permissions-without-kueue.adoc
Outdated
Show resolved
Hide resolved
modules/configuring-the-training-operator-permissions-without-kueue.adoc
Outdated
Show resolved
Hide resolved
modules/configuring-the-training-operator-permissions-without-kueue.adoc
Outdated
Show resolved
Hide resolved
modules/configuring-the-training-operator-permissions-without-kueue.adoc
Outdated
Show resolved
Hide resolved
bredamc
force-pushed
the
ENG-9443_tuning_operator
branch
from
5459498
to
e6f9682
Compare
There was a problem hiding this comment.
Hi @bredamc I'm going ahead and approving since I know you are tight on time.
I have the following unresolved comments (a couple were leftover but most are new). Most are repeating the same comment in different places and are minor adjustments.
The one that confused me is the mostly empty tuning-a-model-by-using-the-training-operator.adoc module.
modules/configuring-the-training-operator-permissions-without-kueue.adoc
Outdated
Show resolved
Hide resolved
bredamc
force-pushed
the
ENG-9443_tuning_operator
branch
from
64a83fc
to
2c204eb
Compare
modules/configuring-the-training-operator-permissions-without-kueue.adoc
Outdated
Show resolved
Hide resolved
|
@VanillaSpoon I've made quite a few changes since you last reviewed, will you please check to make sure you're happy with the latest text? I'll merge for now and send you and @MelissaFlinn a link to a preview, and will make any additional updates (from you both) in a follow-up PR. Thank you both for your reviews and feedback! |
modules/configuring-the-training-operator-permissions-when-not-using-kueue.adoc
Show resolved
Hide resolved
|
See also follow-up PR 369. |
Describe how to use the Training Operator to tune a model