Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENG-9000: Fixes more broken links in cloud doc #340

Merged
merged 1 commit into from
Jun 25, 2024
Merged

ENG-9000: Fixes more broken links in cloud doc #340

merged 1 commit into from
Jun 25, 2024

Conversation

bredamc
Copy link
Contributor

@bredamc bredamc commented Jun 25, 2024

ENG-9000: Fixes more broken links in cloud doc

@bredamc bredamc self-assigned this Jun 25, 2024
@MelissaFlinn
Copy link
Contributor

link fixes look good to me.
one suggestion is to add a comment at the top of the file:
//this module only applies to downstream

@bredamc
Copy link
Contributor Author

bredamc commented Jun 25, 2024 •
edited
Loading

Thanks for the suggestion, @MelissaFlinn. I'd like to clarify with the original author before making that change.

@MelissaFlinn
Copy link
Contributor

/lgtm

@bredamc bredamc merged commit 9174915 into opendatahub-io:main Jun 25, 2024
@bredamc bredamc deleted the ENG-9000_cloud_more_broken_links branch August 9, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bredamc bredamc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bredamc @MelissaFlinn