Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-7634: Updates pipeline example #322

Merged
merged 3 commits into from
Jun 18, 2024

Conversation

bredamc
Copy link
Contributor

@bredamc bredamc commented Jun 15, 2024

ENG-7634: Updates pipeline example

@bredamc bredamc self-assigned this Jun 15, 2024
@bredamc
Copy link
Contributor Author

bredamc commented Jun 15, 2024

@diegolovison Updated as you requested, please review.

Please also advise whether we should update line 175 as follows:
from: ray_fn(openshift_server=openshift_server, openshift_token=openshift_token)
to: ray_fn()

@bredamc bredamc force-pushed the ENG-7634_dw_dsp_workaround branch from 5383eb9 to 9584a59 Compare June 17, 2024 11:28
Copy link

@diegolovison diegolovison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested changed because of the project namespace

@bredamc bredamc force-pushed the ENG-7634_dw_dsp_workaround branch from 9584a59 to 3b87b05 Compare June 17, 2024 21:46
@bredamc
Copy link
Contributor Author

bredamc commented Jun 17, 2024

@diegolovison Ready for review and approval.

Copy link
Contributor

@chtyler chtyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the Asciidoc code and rendered output. A few minor suggestions made. Checked the code blocks in the rendered output for consistency.

@bredamc
Copy link
Contributor Author

bredamc commented Jun 18, 2024

Thanks @chtyler - tweaked the text based on your feedback.

@bredamc bredamc merged commit e1e461d into opendatahub-io:main Jun 18, 2024
@bredamc bredamc deleted the ENG-7634_dw_dsp_workaround branch August 9, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants