Added a note about DSP workloads in 2 modules #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chtyler
reviewed
Jun 14, 2024
| @@ -36,6 +36,11 @@ Manages quotas and how distributed workloads consume them, and manages the queue | |||
|
|
|||
| You can run distributed workloads from data science pipelines, from Jupyter notebooks, or from Microsoft Visual Studio Code files. | |||
|
|
|||
| [NOTE] | |||
| ==== | |||
| Data Science Pipelines (DSP) workloads are not managed by the distributed workloads component, and are not included in the distributed workloads metrics. | |||
There was a problem hiding this comment.
When referring to a specific component and also including the word "component", we should use initial caps:
"..the Distributed Workloads component,...."
There was a problem hiding this comment.
We do not use initcaps to refer to distributed workloads. We also should refer to it as the "distributed workloads feature" for consistency (my fault for providing the wrong text in the original ticket).
There was a problem hiding this comment.
Thanks for the advice, Breda. I have made a note of this for future reference.
chtyler
approved these changes
Jun 17, 2024
sutaakar
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a note about DSP workloads in 2 modules - related jira here: https://issues.redhat.com/browse/RHOAIENG-3022