Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4156: Correcting formatting per ds review feedback. #310

Merged
merged 1 commit into from
Jun 7, 2024
Merged

4156: Correcting formatting per ds review feedback. #310

merged 1 commit into from
Jun 7, 2024

Conversation

grainnejenningsRH
Copy link
Contributor

Corrects downstream formatting, adds condition for upstream steps.

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

chtyler
chtyler approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@chtyler chtyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The formatting issue has been resolved here.

@grainnejenningsRH grainnejenningsRH merged commit bbe1922 into opendatahub-io:main Jun 7, 2024
@grainnejenningsRH grainnejenningsRH deleted the 4156operatorLog_dsFeedback branch June 7, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chtyler chtyler chtyler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grainnejenningsRH @chtyler