RHOAIENG-5433: Adding vLLM #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
z103cb
reviewed
May 30, 2024
dtrifiro
reviewed
May 30, 2024
modules/accessing-inference-endpoint-for-model-deployed-on-single-model-serving-platform.adoc
Outdated
Show resolved
Hide resolved
dtrifiro
reviewed
May 30, 2024
modules/viewing-metrics-for-the-single-model-serving-platform.adoc
Outdated
Show resolved
Hide resolved
dtrifiro
reviewed
May 30, 2024
modules/viewing-metrics-for-the-single-model-serving-platform.adoc
Outdated
Show resolved
Hide resolved
dtrifiro
suggested changes
May 30, 2024
dtrifiro
reviewed
May 31, 2024
modules/accessing-inference-endpoint-for-model-deployed-on-single-model-serving-platform.adoc
Outdated
Show resolved
Hide resolved
dtrifiro
reviewed
May 31, 2024
modules/accessing-inference-endpoint-for-model-deployed-on-single-model-serving-platform.adoc
Outdated
Show resolved
Hide resolved
dtrifiro
reviewed
May 31, 2024
modules/accessing-inference-endpoint-for-model-deployed-on-single-model-serving-platform.adoc
Show resolved
Hide resolved
syaseen-rh
commented
Jun 3, 2024
modules/deploying-models-on-the-single-model-serving-platform.adoc
Outdated
Show resolved
Hide resolved
dtrifiro
reviewed
Jun 4, 2024
modules/viewing-metrics-for-the-single-model-serving-platform.adoc
Outdated
Show resolved
Hide resolved
syaseen-rh
force-pushed
the
RHOAIENG-5433
branch
2 times, most recently
from
37c7452
to
cc4cf69
Compare
syaseen-rh
commented
Jun 7, 2024
modules/accessing-inference-endpoint-for-model-deployed-on-single-model-serving-platform.adoc
Outdated
Show resolved
Hide resolved
syaseen-rh
commented
Jun 7, 2024
modules/accessing-inference-endpoint-for-model-deployed-on-single-model-serving-platform.adoc
Outdated
Show resolved
Hide resolved
z103cb
approved these changes
Jun 7, 2024
syaseen-rh
requested review from
jbyrne-redhat
and removed request for
jbyrne-redhat
jbyrne-redhat
suggested changes
Jun 10, 2024
There was a problem hiding this comment.
Beautiful job with this, @syaseen-rh.
A handful of comments, but all quite minor.
modules/accessing-inference-endpoint-for-model-deployed-on-single-model-serving-platform.adoc
Outdated
Show resolved
Hide resolved
modules/accessing-inference-endpoint-for-model-deployed-on-single-model-serving-platform.adoc
Outdated
Show resolved
Hide resolved
modules/accessing-inference-endpoint-for-model-deployed-on-single-model-serving-platform.adoc
Outdated
Show resolved
Hide resolved
modules/accessing-inference-endpoint-for-model-deployed-on-single-model-serving-platform.adoc
Show resolved
Hide resolved
modules/accessing-inference-endpoint-for-model-deployed-on-single-model-serving-platform.adoc
Show resolved
Hide resolved
modules/viewing-metrics-for-the-single-model-serving-platform.adoc
Outdated
Show resolved
Hide resolved
modules/viewing-metrics-for-the-single-model-serving-platform.adoc
Outdated
Show resolved
Hide resolved
syaseen-rh
force-pushed
the
RHOAIENG-5433
branch
from
cc4cf69
to
576ecf5
Compare
modules/accessing-inference-endpoint-for-model-deployed-on-single-model-serving-platform.adoc
Outdated
Show resolved
Hide resolved
modules/accessing-inference-endpoint-for-model-deployed-on-single-model-serving-platform.adoc
Outdated
Show resolved
Hide resolved
modules/viewing-metrics-for-the-single-model-serving-platform.adoc
Outdated
Show resolved
Hide resolved
jbyrne-redhat
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding vLLM runtime
How Has This Been Tested?
Local Build