Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-5345: Updates code comment and callout for Ray security #266

Merged
merged 1 commit into from
Apr 25, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ def ray_fn(openshift_server: str, openshift_token: str): <1>
ray_cluster_uri = cluster.cluster_uri()
print(ray_dashboard_uri, ray_cluster_uri)

# Enable secure connection to the Ray head pod by exporting the environment variables required for Ray mTLS communication
# Enable Ray client to connect to secure Ray cluster that has mTLS enabled
generate_cert.generate_tls_cert("raytest", "pipeline-example") <9>
generate_cert.export_env("raytest", "pipeline-example")

Expand Down Expand Up @@ -149,7 +149,7 @@ if __name__ == '__main__':
<6> InstaScale is not supported in this release
<7> Creates a Ray cluster using the specified image and configuration
<8> Waits for the Ray cluster to be ready before proceeding
<9> Enables a secure connection for Ray cluster communication; mutual Transport Layer Security (mTLS) is enabled by default in the CodeFlare component in {productname-short}
<9> Enables the Ray client to connect to a secure Ray cluster that has mutual Transport Layer Security (mTLS) enabled; mTLS is enabled by default in the CodeFlare component in {productname-short}
<10> Replace the example details in this section with the details for your workload
<11> Removes the Ray cluster when your workload is finished
<12> Replace the example name and description with the values for your workload
Expand Down