Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4524: Removing branch workaround note. #251

Merged
merged 1 commit into from
Apr 16, 2024
Merged

4524: Removing branch workaround note. #251

merged 1 commit into from
Apr 16, 2024

Conversation

grainnejenningsRH
Copy link
Contributor

Removes a downstream note added in previous release, linking to a branch workaround for RStudio images. This is resolved in 2.9.

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@jstourac
Copy link
Member

As discussed - this should be good for RHOAI 2.9 but still persists for the 2.8.1.

@bredamc
Copy link
Contributor

bredamc commented Apr 16, 2024

LGTM :)

Do we also need to move RHOAIENG-4524 from "Known issues" to "Resolved issues" in the 2.9 Release Notes?

@grainnejenningsRH grainnejenningsRH merged commit 6106885 into opendatahub-io:main Apr 16, 2024
@grainnejenningsRH grainnejenningsRH deleted the RHOAIENG-4524_2.9 branch June 28, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstourac jstourac jstourac approved these changes

@bredamc bredamc bredamc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grainnejenningsRH @jstourac @bredamc