Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eng 3998: Updates doc based on new design for ds project details #249

Merged
merged 13 commits into from
Apr 18, 2024
Merged

Eng 3998: Updates doc based on new design for ds project details #249

merged 13 commits into from
Apr 18, 2024

Conversation

bredamc
Copy link
Contributor

@bredamc bredamc commented Apr 12, 2024 •
edited
Loading

Updates the doc based on new design for ds project details.

Commits grouped as follows:

  • - DataConnection
  • - Model
  • - Permission
  • - Pipeline
  • - Project
  • - Storage
  • - Workbench
  • - Other

@bredamc bredamc marked this pull request as draft April 12, 2024 22:19
jbyrne-redhat
jbyrne-redhat approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@jbyrne-redhat jbyrne-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in the Project details redesign: Models commit (69d0687) look good to me, @bredamc!

grainnejenningsRH
grainnejenningsRH approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@grainnejenningsRH grainnejenningsRH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DSProject, Permission, and Workbench changes LGTM!

grainnejenningsRH
grainnejenningsRH reviewed Apr 17, 2024
View reviewed changes
Copy link
Contributor

@grainnejenningsRH grainnejenningsRH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cluster storage changes LGTM.

@bredamc bredamc force-pushed the ENG-3998_new_ds_projects_design branch from 0c996ed to 1a04e96 Compare April 17, 2024 12:06
grainnejenningsRH
grainnejenningsRH reviewed Apr 17, 2024
View reviewed changes
Copy link
Contributor

@grainnejenningsRH grainnejenningsRH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Data connection and Pipelines LGTM.

One detail for QE to confirm for pipelines once UI bug is resolved. (Whether a successfully configured pipeline server is displayed on the Pipelines tab, or there's further steps needed to view it.)

@bredamc bredamc force-pushed the ENG-3998_new_ds_projects_design branch from abb4f1e to 54f0b84 Compare April 18, 2024 11:08
@bredamc bredamc marked this pull request as ready for review April 18, 2024 11:15
@bredamc
Copy link
Contributor Author

bredamc commented Apr 18, 2024

@grainnejenningsRH Added two more commits to address pipelines and TrustyAI updates. Can you please review and approve? Many thanks :)

@bredamc bredamc force-pushed the ENG-3998_new_ds_projects_design branch from 54f0b84 to 6c5ee67 Compare April 18, 2024 13:22
@bredamc bredamc merged commit 104d48b into opendatahub-io:main Apr 18, 2024
@bredamc bredamc deleted the ENG-3998_new_ds_projects_design branch April 30, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbyrne-redhat jbyrne-redhat jbyrne-redhat approved these changes

@grainnejenningsRH grainnejenningsRH grainnejenningsRH approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bredamc @jbyrne-redhat @grainnejenningsRH