RHOAIENG-4167: adding dashboard options as prereqs #238
Conversation
| @@ -14,6 +14,15 @@ endif::[] | |||
| ifdef::upstream[] | |||
| * If you are using specialized {productname-short} groups, you are part of the admin group (for example, {odh-admin-group}) in OpenShift. | |||
| endif::[] | |||
| * Your cluster administrator has set the value of the `disableModelMesh` dashboard configuration to `false` in the `OdhDashboardConfig` custom resource (CR). | |||
There was a problem hiding this comment.
This is a nice update. Having said that, we wouldn't typically show configuration code in a prerequisite bullet in this way. I think we should mainly rely on the link to the main dashboard configuration documentation.
How about something a little more general, like this?
* A cluster administrator has _not_ edited the {productname-short} dashboard configuration to disable the ModelMesh component. For more information, see link:{rhoaidocshome}/html/managing_resources/customizing-the-dashboard#ref-dashboard-configuration-options_dashboard[Dashboard configuration options].
There was a problem hiding this comment.
Addressed in the latest commit.
syaseen-rh
force-pushed
the
RHOAIENG-4167
branch
from
d08bd35
to
d22b1ca
Compare
| @@ -14,6 +14,7 @@ endif::[] | |||
| ifdef::upstream[] | |||
| * If you are using specialized {productname-short} groups, you are part of the admin group (for example, {odh-admin-group}) in OpenShift. | |||
| endif::[] | |||
| * Your cluster administrator has _not_ edited the {productname-short} dashboard configuration to disable the ability to select ModelMesh as a serving platform. For more information, see link:{rhoaidocshome}/html/managing_resources/customizing-the-dashboard#ref-dashboard-configuration-options_dashboard[Dashboard configuration options]. | |||
There was a problem hiding this comment.
We shouldn't refer to ModelMesh as a serving platform. ModelMesh is the component that underpins the multi-model serving platform.
In that case, we should say "...to disable the ability to select the multi-model serving platform, which uses the ModelMesh component."
I know this description came from here, so we need to get it updated there too. In addition, that description should not use "Serving Platform", capitalized.
There was a problem hiding this comment.
Addressed in latest commit.
| @@ -15,7 +15,9 @@ ifdef::upstream[] | |||
| * If you are using specialized {productname-short} groups, you are part of the admin group (for example, {odh-admin-group}) in OpenShift. | |||
| endif::[] | |||
| * You have installed KServe. | |||
| * Your cluster administrator has _not_ edited the {productname-short} dashboard configuration to disable the ability to select KServe as a serving platform. For more information, see link:{rhoaidocshome}/html/managing_resources/customizing-the-dashboard#ref-dashboard-configuration-options_dashboard[Dashboard configuration options]. | |||
syaseen-rh
changed the title
Description
Adding a few dashboard configuration options as prerequisites within the serving models section, where relevant.
https://issues.redhat.com/browse/RHOAIENG-4167
How Has This Been Tested?
Local build
Preview