-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHOAIENG-4279: Additional steps for updating DSPA crd #224
Conversation
@@ -55,8 +55,31 @@ If you specify incorrect data connection settings, you cannot update these setti | |||
+ | |||
[NOTE] | |||
==== | |||
The external database connection is secured by default. To specify an external database connection that is not secured with TLS, set the value of `database.customExtraParams.tls` to `false` in the `DataSciencePipelinesApplication` custom resource as shown here: | |||
The external database connection is secured by default. To specify an external database connection that is not secured with TLS, after creating the Pipeline Server, set the value of `database.customExtraParams.tls` to `false` in the `DataSciencePipelinesApplication` custom resource: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a difference between a custom resource and a custom resource definition. Looking at the procedure, I think you mean the latter. See: https://docs.openshift.com/container-platform/4.15/operators/understanding/crds/crd-managing-resources-from-crds.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in latest commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@syaseen-rh had it right the first time. What you are editing here is an instance of the Custom Resource Definition, and the instances of CRDs are called custom resources.
If you really wanted to edit the CRD, first, you can't or aren't supposed to, because the CRD is managed by an operator, and second, you'd do it on the YAML tab which shows the CRD itself, not through the Instances tab, which shows the CRs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a note, I'd do steps 1 through 4 in the Search screen instead. This is available both in the Administrator (under Home > Search) as well as in Developer perspective (Search).
You need to have the correct project selected above. I have a wrong one, I should've selected All projects instead of redhat-ods-operator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. A couple of comments.
c11ee39
to
b542a4b
Compare
Description
Adding navigation steps for modifying DSPA custom resource definition
How Has This Been Tested?
local build
Preview