RHOAIENG-4279: Adding note to external db connection section #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiridanek
reviewed
Mar 8, 2024
| + | ||
| [NOTE] | ||
| ==== | ||
| The external database connection is secured by default. To specify an external database that is unencrypted, you will need to set the value of `database.customExtraParams.tls` to `false` in the `DataSciencePipelinesApplication` custom resource as shown here: |
There was a problem hiding this comment.
To specify an external database that is unencrypted
It's the connection to the database that is being encrypted, not the database itself.
Suggested change
| The external database connection is secured by default. To specify an external database that is unencrypted, you will need to set the value of `database.customExtraParams.tls` to `false` in the `DataSciencePipelinesApplication` custom resource as shown here: | |
| The external database connection is secured by default. To specify an external database connection that is not secured with TLS, you will need to set the value of `database.customExtraParams.tls` to `false` in the `DataSciencePipelinesApplication` custom resource as shown here: |
There was a problem hiding this comment.
Thanks @jiridanek, addressed in the latest commit.
grainnejenningsRH
requested changes
Mar 8, 2024
grainnejenningsRH
approved these changes
Mar 8, 2024
diegolovison
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As per https://issues.redhat.com/browse/RHOAIENG-4279,
How Has This Been Tested?
Local build
Preview