New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RHOAIENG-730: RStudio Server notebook images #185

Merged

grainnejenningsRH merged 31 commits into opendatahub-io:main from grainnejenningsRH:RHOAIENG-730

Feb 21, 2024

Contributor

grainnejenningsRH commented Feb 9, 2024

Adds entries for the RStudio Server and CUDA - RStudio Server notebook images in modules/notebook-images-for-data-scientists.adoc and modules/options-for-notebook-server-environments.adoc.

Description

How Has This Been Tested?

Merge criteria:

The commits are squashed in a cohesive manner and have meaningful messages.
Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
The developer has manually tested the changes and verified that the changes work

jstourac approved these changes

View reviewed changes

grainnejenningsRH force-pushed the RHOAIENG-730 branch 5 times, most recently from 12c4ec7 to 7b42224 Compare

February 16, 2024 11:35

jiridanek approved these changes

View reviewed changes

jstourac approved these changes

View reviewed changes

chtyler reviewed

View reviewed changes

modules/configuring-your-ide.adoc Outdated Show resolved Hide resolved

chtyler reviewed

View reviewed changes

modules/configuring-your-ide.adoc Outdated Show resolved Hide resolved

chtyler reviewed

View reviewed changes

modules/configuring-your-ide.adoc Outdated Show resolved Hide resolved

chtyler reviewed

View reviewed changes

modules/configuring-your-ide.adoc Show resolved Hide resolved

chtyler reviewed

View reviewed changes

modules/notebook-images-for-data-scientists.adoc Outdated Show resolved Hide resolved

grainnejenningsRH added 17 commits

February 20, 2024 11:01


          RStudio images - initial draft changes.

58f19ea


          Updates to image descriptions and package lists.

8312d8e


           Minor text corrections.

6b12a10


          Adding steps for downstream.

bfad71d


          Removing white space and unnecessary dash.

4ca0c69


          Wording correction.

f5bb61b


          Updating title.

626c23e


          Testing header link.

28c8693


          Testing header link.

4cda30d


          Adding step notes for RStudio.

65f07ec


          Updates to RStudio Server links.

cc8ab5e


          Updates to align with late changes.

a7b56e4


          Formatting changes.

12e277c


          Fixing list.

4f8c043


          Formatting.

799ee9b


          Correcting bold.

719e17c


          Tabbing changes.

b15858c

grainnejenningsRH added 6 commits

February 20, 2024 11:01


          Tabbing changes.

10c5a16


          Adding if statement.

cd56536


          Adding org-name attributes.

1bed5ca


          Adding imagestream steps.

6d87236


          Peer review style updates.

628fa6d


          Adding tech preview labels for RStudio Server downstream.

72566e0

grainnejenningsRH force-pushed the RHOAIENG-730 branch from 6411163 to 72566e0 Compare

February 20, 2024 11:01

Member

jiridanek commented Feb 20, 2024

The legal warning about AGPL3 will be added here or is it a different PR?

Contributor Author

grainnejenningsRH commented Feb 20, 2024

@jiridanek it will be added to this PR - still waiting to confirm details.

grainnejenningsRH added 8 commits

February 20, 2024 11:52


          Adding generic tech preview note for notebook-images table.

59f71e3


          Removing tech preview body text from code-server table entry.

870bf68


          Adding DS licensing disclaimers, refactoring conditions.

db2a48a


          Removing condition to check formatting.

efd5f2b


          Adjusting disclaimer formatting, testing package table.

993fbc8


          Reordering table notes.

eeb173c


          Resuming conditions for ds content.

2034a6f


          Reorder notes in configuring-your-ide.

494e305

chtyler approved these changes

View reviewed changes

grainnejenningsRH merged commit ea88b84 into opendatahub-io:main

grainnejenningsRH deleted the RHOAIENG-730 branch

February 21, 2024 16:26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet