-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
only create CRB for raw if isvc has auth #364
only create CRB for raw if isvc has auth #364
Conversation
Skipping CI for Draft Pull Request. |
d7762a9
to
02a2b59
Compare
Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com> add odh finalizer to inferenceservice and refactor cleanup logic Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com>
02a2b59
to
fdd70ff
Compare
Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding patch fixed the issue. Approved.
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice refactoring!
I have one question.
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andresllh, israel-hdez, VedantMahabaleshwarkar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
339b6c6
into
opendatahub-io:incubating
Description
Fixes: RHOAIENG-18658
update
conflicts caused in existing tests due adding a finalizerHow Has This Been Tested?
Merge criteria: