Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: added benchmarks for nim ngc catalog #336

Closed

Conversation

TomerFi
Copy link
Contributor

@TomerFi TomerFi commented Dec 13, 2024

Description

This PR includes benchmark functions for exploring the parsing process of the NGC catalog response.
Initially, we were advised to set the page size to 1000. Seeing this as a bit high, considering there were only 39 runtimes available at the time, we set it to 100 and opted to benchmark the parsing process to understand this better.

Jira: NVPE-80

Included in this PR:

  • Benchmark functions
  • Hack tool for creating dummy benchmark documents ignored by git
  • New Makefile targets: make benchmarks and make nim_benchmark_documents

After running a couple of tests, it appears like our code works pretty much the same for 1000 runtimes received by either 1 or 10 pages, snapshots of various tests I ran:

image
image
image

I think the conclusion is that we can either keep the page size at 100 or bump it to 1000.
About this PR, I'm not sure there's a reason for merging this; I'm not sure if we'll need the work included here in the future. I'll open this as a draft and discuss it on Slack.

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link
Contributor

openshift-ci bot commented Dec 13, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: TomerFi
Once this PR has been reviewed and has the lgtm label, please assign vedantmahabaleshwarkar for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Dec 13, 2024

Hi @TomerFi. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
@TomerFi TomerFi force-pushed the benchmark-nim-catalog branch from 657fd67 to ddfb8fd Compare December 23, 2024 22:45
@TomerFi TomerFi marked this pull request as ready for review January 8, 2025 22:14
@TomerFi TomerFi closed this Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants