Migration to kubebuilder v4 #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, the purpose of this PR is to migrate the manifests to kubebuilder v4 or to enable CI? |
This is to migrate the whole project to v4, not just the manifests. |
israel-hdez
force-pushed
the
kubebuilder-v4-migration
branch
from
4bcd840 to
a045a41
Compare
Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com>
israel-hdez
force-pushed
the
kubebuilder-v4-migration
branch
from
a045a41 to
5c5775f
Compare
Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com>
Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com>
Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com>
Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com>
israel-hdez
force-pushed
the
kubebuilder-v4-migration
branch
from
879a4f2 to
fbb3634
Compare
Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com>
israel-hdez
force-pushed
the
kubebuilder-v4-migration
branch
from
fbb3634 to
c82277f
Compare
Pick-up latest changes for model registry. Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com>
Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com>
Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com>
Because setup is not automated, yet. Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com>
spolti
requested changes
Dec 16, 2024
Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com>
Test differences after `go mod tidy` Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com>
Co-authored-by: Filippe Spolti <filippespolti@gmail.com> Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com>
israel-hdez
force-pushed
the
kubebuilder-v4-migration
branch
from
8c3bb65 to
f25139a
Compare
* Pin go-toolset base image in Containerfile. * Add `gosec` linter Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com>
Co-authored-by: Filippe Spolti <filippespolti@gmail.com> Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com>
israel-hdez
force-pushed
the
kubebuilder-v4-migration
branch
from
2618238 to
03e13d2
Compare
3 tasks
* Small change to comments in Makefile, to make the text clearer. * Remove (again) `gosec` linter Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com>
Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com>
|
@spolti Please, take another look. |
spolti
approved these changes
Dec 20, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: israel-hdez, spolti The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
openshift-merge-bot
bot
merged commit 4fad7e6
into
opendatahub-io:incubating
7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How Has This Been Tested?
Merge criteria: