Skip to content
This repository has been archived by the owner on Jan 31, 2024. It is now read-only.

remove external istio crds from odh-model-controller manifests #922

Merged
merged 2 commits into from
Aug 21, 2023

Conversation

VedantMahabaleshwarkar
Copy link
Contributor

@VedantMahabaleshwarkar VedantMahabaleshwarkar commented Aug 21, 2023

Fix odh-model-controller expecting istio PeerAuthentication and Telemetry CRDs even when they are not needed for modelmesh.
Intended to be tested with the accompanying PR to odh-model-controller

Note: the e2e tests on this PR will fail till opendatahub-io/odh-model-controller#68 is merged into the release branch

How Has This Been Tested?

  • Install ODH operator from the stable channel.
  • Copy the odh-core kfdef
  • Change the manifest uri in the kfdef to https://github.com/VedantMahabaleshwarkar/odh-manifests/tarball/crd_fix
  • Install the kfdef
  • Create a OVMS model and verify it is successfully created
  • Verify odh-model-controller is not Crashlooping

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci
Copy link

openshift-ci bot commented Aug 21, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com>
@VedantMahabaleshwarkar VedantMahabaleshwarkar changed the title Crd fix remove external istio crds from odh-model-controller manifests Aug 21, 2023
@VedantMahabaleshwarkar VedantMahabaleshwarkar marked this pull request as ready for review August 21, 2023 18:31
@openshift-ci openshift-ci bot requested review from danielezonca and Jooho August 21, 2023 18:31
@Jooho
Copy link
Contributor

Jooho commented Aug 21, 2023

@Xaenalt did you test this PR?

@Xaenalt
Copy link
Member

Xaenalt commented Aug 21, 2023

No, but the changes in this one are pretty simple, the other one seems to be the one that needs testing

@Jooho
Copy link
Contributor

Jooho commented Aug 21, 2023

/lgtm

@openshift-ci openshift-ci bot removed the lgtm label Aug 21, 2023
Copy link
Contributor

@Jooho Jooho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Aug 21, 2023
@openshift-ci
Copy link

openshift-ci bot commented Aug 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jooho, Xaenalt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@taneem-ibrahim
Copy link

the e2e tests have passed successfully previously, they got re-triggered due to a branch rebase.

@taneem-ibrahim taneem-ibrahim merged commit c86e9f6 into opendatahub-io:master Aug 21, 2023
VedantMahabaleshwarkar added a commit to VedantMahabaleshwarkar/odh-manifests that referenced this pull request Aug 21, 2023
…atahub-io#922)

Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com>
VedantMahabaleshwarkar added a commit to VedantMahabaleshwarkar/odh-manifests that referenced this pull request Aug 21, 2023
…atahub-io#922)

Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com>
VedantMahabaleshwarkar added a commit to VedantMahabaleshwarkar/odh-manifests that referenced this pull request Aug 21, 2023
…atahub-io#922)

Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com>
anishasthana pushed a commit to red-hat-data-services/odh-manifests that referenced this pull request Aug 21, 2023
…atahub-io#922)

Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com>
anishasthana pushed a commit to red-hat-data-services/odh-manifests that referenced this pull request Aug 21, 2023
…atahub-io#922)

Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants