-
Notifications
You must be signed in to change notification settings - Fork 212
remove external istio crds from odh-model-controller manifests #922
remove external istio crds from odh-model-controller manifests #922
Conversation
Skipping CI for Draft Pull Request. |
Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com>
da8feaa
to
c13b5f8
Compare
@Xaenalt did you test this PR? |
No, but the changes in this one are pretty simple, the other one seems to be the one that needs testing |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jooho, Xaenalt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
the e2e tests have passed successfully previously, they got re-triggered due to a branch rebase. |
…atahub-io#922) Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com>
…atahub-io#922) Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com>
…atahub-io#922) Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com>
…atahub-io#922) Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com>
…atahub-io#922) Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com>
Fix odh-model-controller expecting istio
PeerAuthentication
andTelemetry
CRDs even when they are not needed for modelmesh.Intended to be tested with the accompanying PR to odh-model-controller
Note: the e2e tests on this PR will fail till opendatahub-io/odh-model-controller#68 is merged into the release branch
How Has This Been Tested?
stable
channel.https://github.com/VedantMahabaleshwarkar/odh-manifests/tarball/crd_fix
Merge criteria: