Skip to content
This repository has been archived by the owner on Jan 31, 2024. It is now read-only.

Update TrustyAI-Operator manifests to allow for parameterized images #902

Merged
merged 2 commits into from
Aug 17, 2023

Conversation

RobGeada
Copy link
Contributor

@RobGeada RobGeada commented Aug 3, 2023

Allows for parameterized specification of operator + service images within the TrustyAI KFdef; this syncs the odh manifests with the upstream TrustyAI manifests.

Description

See above

How Has This Been Tested?

Mirrors TrustyAI's upstream configuration + CI, and therefore is tested via TrustyAI CI

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci openshift-ci bot requested review from ruivieira and tteofili August 3, 2023 09:32
@LaVLaS
Copy link
Contributor

LaVLaS commented Aug 11, 2023

/approve

The CI run may fail based on recent failures. If so, I'll investigate and merge if the trusty test is successful

@openshift-ci
Copy link

openshift-ci bot commented Aug 11, 2023

@RobGeada: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/411-odh-manifests-e2e 9ac1cc1 link unknown /test 411-odh-manifests-e2e
ci/prow/odh-manifests-e2e 9ac1cc1 link unknown /test odh-manifests-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@LaVLaS
Copy link
Contributor

LaVLaS commented Aug 17, 2023

/approve

Merging since the trusty test are passing

@openshift-ci
Copy link

openshift-ci bot commented Aug 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielezonca, LaVLaS

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@LaVLaS LaVLaS merged commit 9a6c536 into opendatahub-io:master Aug 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants