Sync odh-notebook-controller v1.7 manifests to odh-manifests

[harshad16]

Sync odh-notebook-controller v1.7 manifests to odh-manifests

Description

Fixes: opendatahub-io/kubeflow#56
synced the odh-notebook-controller v1.7 manifests

How Has This Been Tested?

• setup the openshift-cluster
• install opendatahub operator
• deploy the kfdef with this branch
• test the notebook.

Merge criteria:

• The commits are squashed in a cohesive manner and have meaningful messages.
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has manually tested the changes and verified that the changes work

[harshad16]

/retest-required

[atheo89]

/retest-required

[harshad16]

/retest-required

[LaVLaS]

/retest

[atheo89]

Deployed a KfDef using this Pull request

  repos:
    - name: manifests
      uri: 'https://github.com/opendatahub-io/odh-manifests/tarball/pull/875/head'
status:
  conditions:
    - lastUpdateTime: '2023-07-21T08:19:56Z'
      reason: Kubeflow Deployment completed
      status: 'True'
      type: Available

The deployment was completed successfully. The Operator can spawn notebooks from the Jupyter tile or the Data Science Projects without issues. The logs for both controllers don't appear to have any unusual errors.

However, I saw on the trivial_conversion_patch.yaml that an option should be deleted for the 1.7 release.

Overall, /lgtm

[atheo89]

/retest-required

[LaVLaS]

/lgtm
/approve

If the CI test fails due to the trustyAI operator test, I will merge this since the local test ran successfully

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LaVLaS

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• odh-notebook-controller/OWNERS [LaVLaS]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[harshad16]

Rebased and pushed to get the tested fixed

This PR is required as we would like to extend v1.7 notebook-controller in ODH v1.8
Please get this in v1.8
cc: @LaVLaS

[LaVLaS]

/cherry-pick v1.8

[openshift-cherrypick-robot]

@LaVLaS: once the present PR merges, I will cherry-pick it on top of v1.8 in a new PR and assign it to you.

In response to this:

/cherry-pick v1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-cherrypick-robot]

@LaVLaS: new pull request created: #894

In response to this:

/cherry-pick v1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.