Skip to content
This repository has been archived by the owner on Jan 31, 2024. It is now read-only.

Move CUDA indication from the tag to annotations #822

Closed
wants to merge 1 commit into from

Conversation

atheo89
Copy link
Member

@atheo89 atheo89 commented May 17, 2023

This PR includes the CUDA tag version in the annotation list of the image itself rather than the version name.

Related-to: opendatahub-io/notebooks#101

How Has This Been Tested?

  • Deploy ODH with enabled the notebook-images
  • Login to odh-dashboard and navigate into notebooks server spawner
  • Check the version name that has been changed

image

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci
Copy link

openshift-ci bot commented May 17, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@atheo89 atheo89 changed the title Move CUDA indication from the version to annotations Move CUDA indication from the tag to annotations May 17, 2023
@atheo89 atheo89 marked this pull request as ready for review May 19, 2023 08:21
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@harshad16
Copy link
Member

/retest-required

1 similar comment
@atheo89
Copy link
Member Author

atheo89 commented Jun 1, 2023

/retest-required

@atheo89 atheo89 force-pushed the fix-version-name branch from 3f120a3 to 6448bb5 Compare June 1, 2023 08:03
@openshift-ci openshift-ci bot removed the lgtm label Jun 1, 2023
@atheo89
Copy link
Member Author

atheo89 commented Jun 1, 2023

We have chicken-egg problem here the current test can not identify the new changes because the pr that introduce the changes is not yet merged. #802

@openshift-ci
Copy link

openshift-ci bot commented Jun 14, 2023

@atheo89: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/411-odh-manifests-e2e d05b0b2 link true /test 411-odh-manifests-e2e
ci/prow/odh-manifests-e2e d05b0b2 link true /test odh-manifests-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks 100

@openshift-ci openshift-ci bot added the lgtm label Jun 14, 2023
@atheo89 atheo89 force-pushed the fix-version-name branch from d05b0b2 to dc52660 Compare June 14, 2023 13:06
@openshift-ci openshift-ci bot removed the lgtm label Jun 14, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jun 14, 2023

New changes are detected. LGTM label has been removed.

@openshift-ci
Copy link

openshift-ci bot commented Jun 14, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: harshad16
Once this PR has been reviewed and has the lgtm label, please assign vaishnavihire for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@harshad16
Copy link
Member

Covered by: #802
Thanks 💯
closing this.

@harshad16 harshad16 closed this Jun 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants