-
Notifications
You must be signed in to change notification settings - Fork 212
Move CUDA indication from the tag to annotations #822
Conversation
Skipping CI for Draft Pull Request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/retest-required |
1 similar comment
/retest-required |
We have chicken-egg problem here the current test can not identify the new changes because the pr that introduce the changes is not yet merged. #802 |
1e4e79a
to
5b08573
Compare
5b08573
to
d05b0b2
Compare
@atheo89: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Thanks 100
…pendatahub-io#802) Add test notebooks to catch the ubi9 images
d05b0b2
to
dc52660
Compare
New changes are detected. LGTM label has been removed. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: harshad16 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Covered by: #802 |
This PR includes the CUDA tag version in the annotation list of the image itself rather than the version name.
Related-to: opendatahub-io/notebooks#101
How Has This Been Tested?
Merge criteria: