Skip to content
This repository has been archived by the owner on Jan 31, 2024. It is now read-only.

Add tests for DSP experiments #795

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

DharmitD
Copy link
Member

@DharmitD DharmitD commented Apr 21, 2023

Adding end to end tests for the Data Science Pipelines Operator / Application that test experiments

Relevant PR: opendatahub-io/data-science-pipelines-operator#95

Description

How Has This Been Tested?

  • Deploy a DSPA instance
  • Run the following commands:
    • make build -- to create the test container image
    • make run TESTS_REGEX=ml-pipelines
      • This will run the container image locally
      • It will further apply the kfdef defined in the kfctl_openshift.yaml file.
      • If you have the kfdef installed already, you can run this instead:
        make run SKIP_INSTALL=true SKIP_KFDEF_INSTALL=true

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci openshift-ci bot requested review from anishasthana and LaVLaS April 21, 2023 20:45
@DharmitD DharmitD marked this pull request as draft April 21, 2023 20:45
@DharmitD DharmitD marked this pull request as ready for review April 21, 2023 20:46
@DharmitD
Copy link
Member Author

/test odh-manifests-e2e

@rimolive
Copy link
Contributor

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Apr 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gmfrasca, VaishnaviHire

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit c7f3019 into opendatahub-io:master Apr 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants