Fix tests to support changes introduced by 1.5 Operator

[VaishnaviHire]

Description

• The deployment name for the operator is updated to opendatahub-operator-controller-manager. Update the tests to use the new name.
• DSP Operator tests are failing because, OpenShift Pipelines Operator is being installed in the namespace other than the KfDef namespace. This is not supported, since we have added ownerreferences to KfDef

How Has This Been Tested?

Merge criteria:

• The commits are squashed in a cohesive manner and have meaningful messages.
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has manually tested the changes and verified that the changes work

[harshad16]

/lgtm
/approve
thanks 👍

[VaishnaviHire]

@LaVLaS Can you review this. This will unblock the failing odh-manifests tests

[anishasthana]

/retest

[anishasthana]

/retest

[harshad16]

/test odh-manifests-e2e

[VaishnaviHire]

DSP Operator tests are failing because, OpenShift Pipelines Operator is being installed in the namespace other than the KfDef namespace. I had opened #774 to fix it. Since these PRs are blocking one another, I am including both commits in this PR.

[LaVLaS]

@VaishnaviHire Since the openshift-pipelines installation is just an OLM subscription, we can simplify the workflow by apllying the openshift-pipelines subscription as part of the tests/scripts/install.sh script and delete the openshift-pipelines test since that was from the older ODH releases where we bundled openshift-pipelines as a component

If you this PR will pass right now then we can keep the current working code and I will submit a follow-up PR to update that workflow

[VaishnaviHire]

@VaishnaviHire Since the openshift-pipelines installation is just an OLM subscription, we can simplify the workflow by apllying the openshift-pipelines subscription as part of the tests/scripts/install.sh script and delete the openshift-pipelines test since that was from the older ODH releases where we bundled openshift-pipelines as a component

If you this PR will pass right now then we can keep the current working code and I will submit a follow-up PR to update that workflow

Yes, agreed. I will update the PR to directly use the subscription.

[VaishnaviHire]

Failed due to issues creating test clusters.

/test odh-manifests-e2e

/test 411-odh-manifests-e2e

[anishasthana]

/retest-required

[openshift-ci]

@VaishnaviHire: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/49-images	0b54bd9	link	true	/test 49-images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[VaishnaviHire]

Expected error in ci/prow/odh-manifests-e2e for 4.12 cluster.

oc get-token.. is depricated. DS Pipelines tests need to be updated to fix this. I think we just need to remove the if condition in the linked test. I will can add additional commit in this PR.

[anishasthana]

/lgtm

[anishasthana]

/merge-status

[LaVLaS]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anishasthana, harshad16, LaVLaS

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [LaVLaS,anishasthana]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[VaishnaviHire]

Merging this since the tests passed