Skip to content
This repository has been archived by the owner on Jan 31, 2024. It is now read-only.

Cleanup the kfdef and use odh-core kfdef as the standard for ODH Core deployments #672

Merged
merged 1 commit into from
Oct 26, 2022
Merged

Cleanup the kfdef and use odh-core kfdef as the standard for ODH Core deployments #672

merged 1 commit into from
Oct 26, 2022

Conversation

LaVLaS
Copy link
Contributor

@LaVLaS LaVLaS commented Sep 1, 2022 •
edited
Loading

Signed-off-by: Landon LaSmith LLaSmith@redhat.com

Closes #658

Description

How Has This Been Tested?

ODH Core kfdefs deploy the components successfully

Merge criteria:

You can deploy ODH successfullying using the odh-core kfdef.

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@LaVLaS LaVLaS added this to the ODH 1.4.0 Release milestone Sep 1, 2022
@shalberd
Copy link
Contributor

shalberd commented Sep 2, 2022 •
edited
Loading

Hey, regarding the change with Kubeflow Notebook Controller and no more Jupyterlab (repoRef:
name: manifests
path: jupyterhub/jupyterhub): Do you want me to integrate the change of supporting private PKI trusted CAs to this new component instead? Talking about #669
That is, will Jupyterhub "traditional" be gone in v1.4.0 of Open Data Hub operator?

@cfchase
Copy link
Member

cfchase commented Sep 16, 2022 •
edited
Loading

Have you seen this error when deploying odh-core-experimental?

time="2022-09-16T14:47:31Z" level=error msg="Error evaluating kustomization manifest for odh-dashboard: accumulating resources: recursed merging from path 'base': may not add resource with an already registered id: rbac.authorization.k8s.io_v1_Role|~X|odh-dashboard"

@LaVLaS LaVLaS force-pushed the kfdef-cleanup branch 2 times, most recently from c2a5a38 to 0520f9a Compare October 21, 2022 01:00
@LaVLaS
Copy link
Contributor Author

LaVLaS commented Oct 24, 2022

/retest

@LaVLaS LaVLaS changed the title WIP: Add KfDefs for ODH Core & ODH Core Experimental WIP: Add KfDefs for ODH Core Oct 25, 2022
@LaVLaS
Copy link
Contributor Author

LaVLaS commented Oct 25, 2022

/retest

@LaVLaS
Add odh-core kfdef as the default for ODH deployments
6f003d7 
* Remove older kfdefs
* Use odh-core kfdef for CI test deployment
* Disable JupyterHub CI tests

Signed-off-by: Landon LaSmith <LLaSmith@redhat.com>
@LaVLaS LaVLaS changed the title WIP: Add KfDefs for ODH Core Add KfDefs for ODH Core Oct 26, 2022
@LaVLaS LaVLaS changed the title Add KfDefs for ODH Core Cleanup the kfdef and use odh-core kfdef as the standard for ODH Core deployments Oct 26, 2022
@LaVLaS
Copy link
Contributor Author

LaVLaS commented Oct 26, 2022

odh-core-experiment kfdef requires more changes in the respective repos so I am moving it to #689 while we resolve issue with those deployments and stop this from blocking the ODH 1.4 release

anishasthana
anishasthana approved these changes Oct 26, 2022
View reviewed changes
Copy link
Member

@anishasthana anishasthana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 26, 2022
@openshift-ci
Copy link

openshift-ci bot commented Oct 26, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anishasthana

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit bd8cfa9 into opendatahub-io:master Oct 26, 2022
@LaVLaS LaVLaS deleted the kfdef-cleanup branch October 26, 2022 22:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cfchase cfchase cfchase left review comments

@anishasthana anishasthana anishasthana approved these changes

@crobby crobby Awaiting requested review from crobby

Assignees

@anishasthana anishasthana

Labels
approved lgtm
Projects
None yet
Milestone
ODH 1.4.0 Release
Development

Successfully merging this pull request may close these issues.

Add odh-core KfDef example
5 participants
@LaVLaS @shalberd @cfchase @anishasthana @openshift-merge-robot