Skip to content
This repository has been archived by the owner on Jan 31, 2024. It is now read-only.

Gather ODH logs using must-gather #639

Merged

Conversation

VaishnaviHire
Copy link
Member

@VaishnaviHire VaishnaviHire commented Aug 11, 2022

Fixes #654

How Has This Been Tested?

  1. Deploy core ODH components
  2. https://github.com/VaishnaviHire/odh-manifests/tree/add_must_gather/must-gather#usage

Follow-up tasks:

  1. Add log-collection to CI Artifacts2.
  2. Add component specific script to collect logs for ML pipelines component

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci openshift-ci bot requested review from crobby and LaVLaS August 11, 2022 13:18
@VaishnaviHire VaishnaviHire changed the title [WIP] Gather ODH logs Gather ODH logs using must-gather Sep 28, 2022
@VaishnaviHire VaishnaviHire requested review from Jooho and samuelvl and removed request for crobby October 3, 2022 11:58
@VaishnaviHire VaishnaviHire force-pushed the add_must_gather branch 2 times, most recently from 3f48c93 to 8bde93a Compare October 3, 2022 12:01
Copy link
Contributor

@LaVLaS LaVLaS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Oct 12, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LaVLaS

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@LaVLaS
Copy link
Contributor

LaVLaS commented Oct 13, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 13, 2022
@openshift-merge-robot openshift-merge-robot merged commit 0dfd0d6 into opendatahub-io:master Oct 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Logging in ODH Components
3 participants