Skip to content
This repository has been archived by the owner on Jan 31, 2024. It is now read-only.

Model Mesh installation steps #630

Merged

Conversation

DharmitD
Copy link
Member

@DharmitD DharmitD commented Aug 5, 2022

Steps to install Model Mesh on ODH using the ODH Model Controller.

@openshift-ci openshift-ci bot requested review from LaVLaS and VaishnaviHire August 5, 2022 22:22
@DharmitD DharmitD marked this pull request as draft August 5, 2022 22:22
@DharmitD DharmitD requested a review from crobby August 5, 2022 22:23
@DharmitD DharmitD marked this pull request as ready for review August 8, 2022 20:29
@DharmitD DharmitD changed the title Draft: Model Mesh installation steps Model Mesh installation steps Aug 8, 2022
@DharmitD DharmitD force-pushed the model-mesh-install branch 3 times, most recently from c5be429 to 579f3a1 Compare August 9, 2022 14:01
Copy link
Member

@anishasthana anishasthana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

@crobby crobby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm...looking at test fail

@crobby
Copy link
Contributor

crobby commented Aug 9, 2022

/test all

@anishasthana
Copy link
Member

The CI failures are unrelated to @DharmitD 's changes

Copy link
Contributor

@LaVLaS LaVLaS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@DharmitD DharmitD force-pushed the model-mesh-install branch from 579f3a1 to d5d0d2f Compare August 11, 2022 17:06
@openshift-ci openshift-ci bot removed the lgtm label Aug 11, 2022
Copy link
Member

@anishasthana anishasthana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Aug 11, 2022
@openshift-ci
Copy link

openshift-ci bot commented Aug 11, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anishasthana, crobby, LaVLaS

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [LaVLaS,anishasthana,crobby]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rimolive
Copy link
Contributor

/lgtm

@openshift-merge-robot openshift-merge-robot merged commit db23f0f into opendatahub-io:master Aug 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants