Fix parameter placement for hive-metastore resource requests and limits

[rimolive]

No description provided.

[VaishnaviHire]

I think we would also need to update the default values in params.env

odh-manifests/trino/base/params.env

Line 8 in d2fbbe3

hive_metastore_memory_request=1Gi

[rimolive]

I think we would also need to update the default values in params.env

odh-manifests/trino/base/params.env

Line 8 in d2fbbe3

hive_metastore_memory_request=1Gi

I made the changes in README with the default values for each parameter. Are you suggesting other default values or just ensure the values in README are the same as in params.env?

[Jooho]

It looks trino_cpu_request default value is also wrong. From README, trino_cpu_request default is 1 but it is actually 300m in params.env. If it is ok, could you update the param in the README file as well?

[VaishnaviHire]

I think we would also need to update the default values in params.env

odh-manifests/trino/base/params.env

Line 8 in d2fbbe3

hive_metastore_memory_request=1Gi

I made the changes in README with the default values for each parameter. Are you suggesting other default values or just ensure the values in README are the same as in params.env?

Sorry I missed it, the updates you made in README seem to match with params.env

However I get following error with these changes:

time="2022-06-21T16:55:08Z" level=warning msg="Encountered error applying application trino:  (kubeflow.error): Code 500 with message: Apply.Run : error when creating \"/tmp/kout783067535\": StatefulSet in version \"v1\" cannot be handled as a StatefulSet: v1.StatefulSet.Spec: v1.StatefulSetSpec.Template: v1.PodTemplateSpec.Spec: v1.PodSpec.Containers: []v1.Container: v1.Container.Resources: v1.ResourceRequirements.Requests: unmarshalerDecoder: quantities must match the regular expression '^([+-]?[0-9.]+)([eEinumkKMGTP]*[-+]?[0-9]*)$', error found in #10 byte of ...|_request)\",\"memory\":|..., bigger context ...|,\"requests\":{\"cpu\":\"$(hive_metastore_cpu_request)\",\"memory\":\"512Mi\"}},\"volumeMounts\":[{\"mountPath\":\"|..."

I think we would need to add following in params.yaml ?

  - path: spec/template/spec/containers[]/resources/requests/cpu
    kind: StatefulSet
  - path: spec/template/spec/containers[]/resources/limiys/cpu
    kind: StatefulSet
  - path: spec/template/spec/containers[]/resources/requests/memory
    kind: StatefulSet
  - path: spec/template/spec/containers[]/resources/limits/memory
    kind: StatefulSet

[rimolive]

Ah, good point! I thought those are already covered by the lines already, but hive-metastore is a StatefulSet, not a Deployment object.

[VaishnaviHire]

Worked well with ocp 4.10

/lgtm

[LaVLaS]

/lgtm

Also worked for me on OCP 4.10

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LaVLaS, rimolive

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [LaVLaS]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment