Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE #883: feat: add data-testid attribute for loading spinner #910

Conversation

jstetina
Copy link

@jstetina jstetina commented Feb 20, 2025

Closes #883

Description

Add data-testid attribute to a initial loading spinner element

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci openshift-ci bot requested review from atheo89 and jiridanek February 20, 2025 13:40
Copy link
Contributor

openshift-ci bot commented Feb 20, 2025

Hi @jstetina. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added size/m and removed size/xs labels Feb 20, 2025
@jiridanek
Copy link
Member

/ok-to-test

Comment on lines 26 to 28
@allure.description(
"Check that the HTML for the spinner is contained in the initial page."
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your line length limit is a bit too low, imo; this would be a lot better to have everything on single line

<circle
class="pf-v6-c-spinner__path"
data-testid="loading-spinner-initial"
="50"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

@jiridanek jiridanek changed the title ISSUE #883: feat: add data-testid attribute for loading spinner ISSUE #883: feat: add data-testid attribute for loading spinner Feb 20, 2025
@openshift-ci openshift-ci bot added size/m and removed size/m labels Feb 20, 2025
Copy link
Member

@jiridanek jiridanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix the typo

@openshift-ci openshift-ci bot added size/s and removed size/m labels Feb 20, 2025
@jstetina jstetina requested a review from jiridanek February 20, 2025 15:33
@jiridanek
Copy link
Member

/ok-to-test

@jiridanek
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Feb 20, 2025
@jiridanek jiridanek added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Feb 20, 2025
@jstourac
Copy link
Member

/lgtm

@jiridanek
Copy link
Member

/approve

thanks for the work

Copy link
Contributor

openshift-ci bot commented Feb 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiridanek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jiridanek
Copy link
Member

/override "Red Hat Konflux"

Copy link
Contributor

openshift-ci bot commented Feb 20, 2025

@jiridanek: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • Red Hat Konflux

Only the following failed contexts/checkruns were expected:

  • build
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override "Red Hat Konflux"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jiridanek
Copy link
Member

/ok-to-test

@jiridanek jiridanek merged commit 77edf72 into opendatahub-io:refactor/konflux-migration Feb 20, 2025
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test size/s tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pity we didn't put some testid attribute to this our extra element against which we could check here...
3 participants