-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ISSUE #883: feat: add data-testid
attribute for loading spinner
#910
ISSUE #883: feat: add data-testid
attribute for loading spinner
#910
Conversation
Hi @jstetina. Thanks for your PR. I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
@allure.description( | ||
"Check that the HTML for the spinner is contained in the initial page." | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
your line length limit is a bit too low, imo; this would be a lot better to have everything on single line
<circle | ||
class="pf-v6-c-spinner__path" | ||
data-testid="loading-spinner-initial" | ||
="50" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo
data-testid
attribute for loading spinner
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please fix the typo
/ok-to-test |
/lgtm |
/lgtm |
/approve thanks for the work |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jiridanek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override "Red Hat Konflux" |
@jiridanek: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
77edf72
into
opendatahub-io:refactor/konflux-migration
Closes #883
testid
attribute to this our extra element against which we could check here... #883Description
Add data-testid attribute to a initial loading spinner element
How Has This Been Tested?
Merge criteria: