Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include script on workbench to copy runtime-image json to relevant path #909

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

atheo89
Copy link
Member

@atheo89 atheo89 commented Feb 20, 2025

Related to: https://issues.redhat.com/browse/RHOAIENG-20241

Description

This PR include the following changes:

  • Modifies the elyra.sh script to copy the content from mount path /opt/app-root/pipeline-runtimes/ to elyra path /opt/app-root/share/jupyter/metadata/runtime-images/ this take place when the DS notebook starts up. The reason is to avoid override the runtime images that the user may have import by himself.

(quay.io/rh_ee_atheodor/workbench-images@sha256:f2bc105afab97575007a5743e39cc4c045fa276ba8612b6a8241758d48711913) custom_v3

How Has This Been Tested?

This changes have been tested along with notebook controller (PR soon) by importing the new data science image generated by this PR

These are the logs when the datachience notebook when it get spin up on cluster.
The list of .json comes from the mount assigned on the notebook from the notebook-controller
image

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci openshift-ci bot requested review from jiridanek and paulovmr February 20, 2025 09:44
Copy link
Contributor

openshift-ci bot commented Feb 20, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from atheo89. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added size/xs and removed size/m labels Feb 20, 2025
@atheo89 atheo89 changed the title Remove json runtime files from the data science notebook Include script on workbench to copy runtime-image json to relevant path Feb 20, 2025
@openshift-ci openshift-ci bot added size/xs and removed size/xs labels Feb 20, 2025
@atheo89
Copy link
Member Author

atheo89 commented Feb 20, 2025

The runtime .json files will be removed later on a separated PR, basically when we will be ready to include to the project the mounting from the odh-notebook-controller

Copy link
Contributor

openshift-ci bot commented Feb 20, 2025

@atheo89: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/notebook-rocm-jupyter-pyt-ubi9-python-3-11-pr-image-mirror b23bb0c link true /test notebook-rocm-jupyter-pyt-ubi9-python-3-11-pr-image-mirror
ci/prow/rocm-notebooks-e2e-tests b23bb0c link true /test rocm-notebooks-e2e-tests
ci/prow/notebooks-ubi9-e2e-tests b23bb0c link true /test notebooks-ubi9-e2e-tests
ci/prow/notebook-rocm-jupyter-tf-ubi9-python-3-11-pr-image-mirror b23bb0c link true /test notebook-rocm-jupyter-tf-ubi9-python-3-11-pr-image-mirror
ci/prow/images b23bb0c link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant