-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include script on workbench to copy runtime-image json to relevant path #909
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
0bddf27
to
517b7bc
Compare
517b7bc
to
b23bb0c
Compare
The runtime .json files will be removed later on a separated PR, basically when we will be ready to include to the project the mounting from the |
@atheo89: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Related to: https://issues.redhat.com/browse/RHOAIENG-20241
Description
This PR include the following changes:
elyra.sh
script to copy the content from mount path/opt/app-root/pipeline-runtimes/
to elyra path/opt/app-root/share/jupyter/metadata/runtime-images/
this take place when the DS notebook starts up. The reason is to avoid override the runtime images that the user may have import by himself.(
quay.io/rh_ee_atheodor/workbench-images@sha256:f2bc105afab97575007a5743e39cc4c045fa276ba8612b6a8241758d48711913
)custom_v3
How Has This Been Tested?
This changes have been tested along with notebook controller (PR soon) by importing the new data science image generated by this PR
These are the logs when the datachience notebook when it get spin up on cluster.

The list of .json comes from the mount assigned on the notebook from the notebook-controller
Merge criteria: