Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: chore(.github/renovate.json): add doc links and disable the managers we are not ready to have around yet #902

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

jiridanek
Copy link
Member

@jiridanek jiridanek commented Feb 18, 2025

https://issues.redhat.com/browse/RHOAIENG-18402

Description

Based on the defaults at https://github.com/konflux-ci/mintmaker/blob/main/config/renovate/renovate.json

We need to stop MintMaker/Renovate from trying to update all our Pipfiles.

How Has This Been Tested?

https://docs.renovatebot.com/config-validation/

$ (cd .github; npx --yes --package renovate -- renovate-config-validator)

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

…managers we are not ready to have around yet
@openshift-ci openshift-ci bot requested review from caponetto and paulovmr February 18, 2025 11:20
@openshift-ci openshift-ci bot added size/m and removed size/m labels Feb 18, 2025
@jiridanek
Copy link
Member Author

/override ci/prow/images
n/a for this change

Copy link
Contributor

openshift-ci bot commented Feb 18, 2025

@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/images

In response to this:

/override ci/prow/images
n/a for this change

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jstourac
Copy link
Member

/lgtm

@jiridanek
Copy link
Member Author

Thanks, I hope it'll work. It's hard to test this stuff in advance.

/approve

Copy link
Contributor

openshift-ci bot commented Feb 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiridanek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit ce449a8 into opendatahub-io:main Feb 18, 2025
7 checks passed
@jiridanek jiridanek deleted the renovate branch February 18, 2025 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants