-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHOAIENG-18933: removal of the huggingface dependency in our images #893
RHOAIENG-18933: removal of the huggingface dependency in our images #893
Conversation
It was decided that we'll keep the kubeflow-training python package installed as introduced via [1] but we will ditch the extra dependency on the huggingface package which causes huge bump in our image sizes. [1] https://issues.redhat.com/browse/RHOAIENG-12822 * https://issues.redhat.com/browse/RHOAIENG-18933
Skipping CI for Draft Pull Request. |
Let's wait for the GHA to update the Pipfile.locks renewal. Then, I will probably need to run the Update: actually the GHA for the Pipfile.lock renewal updates also requirements.txt files - so no extra work needed. Let's review the results and test that somehow now. |
looks legit to me |
/lgtm |
Checking the image size on https://quay.io/repository/opendatahub/workbench-images?tab=tags&tag=latest compared to what was reported (some of the openshift-ci builds failed so aren't mentioned here):
others:
In general, the patch seem to work and the size are back to "normal" again. |
/lgtm |
Thank you for your reviews! Let's get this in so we can move on. /override ci/prow/notebook-cuda-jupyter-min-ubi9-python-3-11-pr-image-mirror /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jstourac The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@jstourac: Overrode contexts on behalf of jstourac: ci/prow/codeserver-notebook-e2e-tests, ci/prow/images, ci/prow/notebook-cuda-jupyter-min-ubi9-python-3-11-pr-image-mirror, ci/prow/notebook-cuda-jupyter-tf-ubi9-python-3-11-pr-image-mirror, ci/prow/notebook-jupyter-pytorch-ubi9-python-3-11-pr-image-mirror, ci/prow/notebook-rocm-jupyter-pyt-ubi9-python-3-11-pr-image-mirror, ci/prow/notebook-rocm-jupyter-tf-ubi9-python-3-11-pr-image-mirror, ci/prow/notebooks-ubi9-e2e-tests, ci/prow/rocm-notebooks-e2e-tests, ci/prow/rocm-runtimes-ubi9-e2e-tests, ci/prow/runtime-rocm-pytorch-ubi9-python-3-11-pr-image-mirror, ci/prow/runtimes-ubi9-e2e-tests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/override ci/prow/codeserver-notebook-e2e-tests |
@jstourac: Overrode contexts on behalf of jstourac: ci/prow/codeserver-notebook-e2e-tests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
e2cb5db
into
opendatahub-io:main
It was decided that we'll keep the kubeflow-training python package installed as introduced via [1] but we will ditch the extra dependency on the huggingface package which causes huge bump in our image sizes.
[1] https://issues.redhat.com/browse/RHOAIENG-12822
Description
How Has This Been Tested?
Merge criteria: