Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHOAIENG-18933: removal of the huggingface dependency in our images #893

Merged

Conversation

jstourac
Copy link
Member

It was decided that we'll keep the kubeflow-training python package installed as introduced via [1] but we will ditch the extra dependency on the huggingface package which causes huge bump in our image sizes.

[1] https://issues.redhat.com/browse/RHOAIENG-12822

Description

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

It was decided that we'll keep the kubeflow-training python package
installed as introduced via [1] but we will ditch the extra dependency
on the huggingface package which causes huge bump in our image sizes.

[1] https://issues.redhat.com/browse/RHOAIENG-12822

* https://issues.redhat.com/browse/RHOAIENG-18933
Copy link
Contributor

openshift-ci bot commented Feb 10, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the size/s label Feb 10, 2025
@jstourac
Copy link
Member Author

jstourac commented Feb 10, 2025

Let's wait for the GHA to update the Pipfile.locks renewal. Then, I will probably need to run the ./ci/generate_code.sh again, let's wait and see.

Update: actually the GHA for the Pipfile.lock renewal updates also requirements.txt files - so no extra work needed. Let's review the results and test that somehow now.

@openshift-ci openshift-ci bot added size/xxl and removed size/s labels Feb 10, 2025
@jiridanek
Copy link
Member

looks legit to me

@jstourac jstourac added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Feb 10, 2025
@astefanutti
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Feb 10, 2025
@jstourac jstourac marked this pull request as ready for review February 11, 2025 08:02
@jstourac
Copy link
Member Author

Checking the image size on https://quay.io/repository/opendatahub/workbench-images?tab=tags&tag=latest compared to what was reported (some of the openshift-ci builds failed so aren't mentioned here):

  • odh-generic-data-science - 900MB -> 4GB
    • jupyter-datascience-ubi9-python-3.11-pr-893 -> 961.8 MiB
  • cuda-jupyter-tensorflow - 6.8GB -> 11.0GB
  • odh-pytorch-notebook too - 8.3GB -> 10.6GB
  • odh-trustyai-notebook - 4.1GB -> 7.1GB
    • jupyter-trustyai-ubi9-python-3.11-pr-893 -> 4.1 GiB
  • code-server - 900MB -> 4GB
    • codeserver-ubi9-python-3.11-pr-893 -> 893.4 MiB
  • rocm-jupyter-pytorch - 6.4GB -> 9.5GB
  • rocm-jupyter-tensorflow - 5.7GB -> 8.7GB

others:

  • runtime-pytorch-ubi9-python-3.11-pr-893 | 3.8 GiB
  • runtime-datascience-ubi9-python-3.11-pr-893 | 866.5 MiB
  • jupyter-minimal-ubi9-python-3.11-pr-893 | 528.6 MiB

In general, the patch seem to work and the size are back to "normal" again.

@atheo89
Copy link
Member

atheo89 commented Feb 11, 2025

/lgtm

@jstourac
Copy link
Member Author

Thank you for your reviews!

Let's get this in so we can move on.

/override ci/prow/notebook-cuda-jupyter-min-ubi9-python-3-11-pr-image-mirror
/override ci/prow/notebook-cuda-jupyter-tf-ubi9-python-3-11-pr-image-mirror
/override ci/prow/notebook-jupyter-pytorch-ubi9-python-3-11-pr-image-mirror
/override ci/prow/notebooks-ubi9-e2e-tests
/override ci/prow/rocm-notebooks-e2e-tests
/override ci/prow/rocm-runtimes-ubi9-e2e-tests
/override ci/prow/runtimes-ubi9-e2e-tests
/override ci/prow/codeserver-notebook-e2e-tests
/override ci/prow/images
/override ci/prow/notebook-rocm-jupyter-pyt-ubi9-python-3-11-pr-image-mirror
/override ci/prow/notebook-rocm-jupyter-tf-ubi9-python-3-11-pr-image-mirror
/override ci/prow/runtime-rocm-pytorch-ubi9-python-3-11-pr-image-mirror

/approve

Copy link
Contributor

openshift-ci bot commented Feb 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jstourac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Feb 11, 2025

@jstourac: Overrode contexts on behalf of jstourac: ci/prow/codeserver-notebook-e2e-tests, ci/prow/images, ci/prow/notebook-cuda-jupyter-min-ubi9-python-3-11-pr-image-mirror, ci/prow/notebook-cuda-jupyter-tf-ubi9-python-3-11-pr-image-mirror, ci/prow/notebook-jupyter-pytorch-ubi9-python-3-11-pr-image-mirror, ci/prow/notebook-rocm-jupyter-pyt-ubi9-python-3-11-pr-image-mirror, ci/prow/notebook-rocm-jupyter-tf-ubi9-python-3-11-pr-image-mirror, ci/prow/notebooks-ubi9-e2e-tests, ci/prow/rocm-notebooks-e2e-tests, ci/prow/rocm-runtimes-ubi9-e2e-tests, ci/prow/runtime-rocm-pytorch-ubi9-python-3-11-pr-image-mirror, ci/prow/runtimes-ubi9-e2e-tests

In response to this:

Thank you for your reviews!

Let's get this in so we can move on.

/override ci/prow/notebook-cuda-jupyter-min-ubi9-python-3-11-pr-image-mirror
/override ci/prow/notebook-cuda-jupyter-tf-ubi9-python-3-11-pr-image-mirror
/override ci/prow/notebook-jupyter-pytorch-ubi9-python-3-11-pr-image-mirror
/override ci/prow/notebooks-ubi9-e2e-tests
/override ci/prow/rocm-notebooks-e2e-tests
/override ci/prow/rocm-runtimes-ubi9-e2e-tests
/override ci/prow/runtimes-ubi9-e2e-tests
/override ci/prow/codeserver-notebook-e2e-tests
/override ci/prow/images
/override ci/prow/notebook-rocm-jupyter-pyt-ubi9-python-3-11-pr-image-mirror
/override ci/prow/notebook-rocm-jupyter-tf-ubi9-python-3-11-pr-image-mirror
/override ci/prow/runtime-rocm-pytorch-ubi9-python-3-11-pr-image-mirror

/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jstourac
Copy link
Member Author

/override ci/prow/codeserver-notebook-e2e-tests

Copy link
Contributor

openshift-ci bot commented Feb 11, 2025

@jstourac: Overrode contexts on behalf of jstourac: ci/prow/codeserver-notebook-e2e-tests

In response to this:

/override ci/prow/codeserver-notebook-e2e-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit e2cb5db into opendatahub-io:main Feb 11, 2025
37 checks passed
@jstourac jstourac deleted the kftHuggingfaceRemoval branch February 11, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/xxl tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants