Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "RHOAIENG-17306, RHOAIENG-17307, RHOAIENG-17308: feat(workbenches): tolerate IPv6 environments in codeserver, jupyterlab and rstudio" #877

Merged
merged 2 commits into from
Jan 30, 2025

Conversation

jiridanek
Copy link
Member

@jiridanek jiridanek commented Jan 30, 2025

We aren't yet ready to take this into ODH release or further downstream.

Reverts #827

GitHub Action (it's actually part of the checks below, because PR is from a branch in the same repo)

…hes): tolerate IPv6 environments in codeserver, jupyterlab and rstudio"
@openshift-ci openshift-ci bot requested review from atheo89 and daniellutz January 30, 2025 10:43
@openshift-ci openshift-ci bot added the size/m label Jan 30, 2025
@jiridanek
Copy link
Member Author

jiridanek commented Jan 30, 2025

Hopefully this will fail the IPv6 tests. And then I will add one more commit here that removes or disables that test.

edit: good, the failure is there

FAILED tests/containers/workbenches/workbench_image_test.py::TestWorkbenchImage::test_ipv6_only[ghcr.io/opendatahub-io/notebooks/workbench-images:jupyter-minimal-ubi9-python-3.11-revert-827-clean-fix-ipv6-issue_227e3064ad9d1d03c2dceb4a7ef8eacaf8fdd660] - TimeoutError: Wait time (120s) exceeded for _connect(args: (), kwargs: {'container_host': 'fd00::2', 'container_port': 8888}). Exception: <urlopen error [Errno 111] Connection refused>

edit2: rstudio fails this test differently, so jupyterlab and codeserver are above, and just ftr here's rstudio

FAILED tests/containers/workbenches/workbench_image_test.py::TestWorkbenchImage::test_ipv6_only[ghcr.io/opendatahub-io/notebooks/workbench-images:rstudio-c9s-python-3.11-revert-827-clean-fix-ipv6-issue_227e3064ad9d1d03c2dceb4a7ef8eacaf8fdd660] - AssertionError: assert 'exited' != 'exited'
 +  where 'exited' = <Container: 84fa1eca8d73>.status
 +    where <Container: 84fa1eca8d73> = get_wrapped_container()
 +      where get_wrapped_container = <workbench_image_test.WorkbenchContainer object at 0x7f0ebfb157f0>.get_wrapped_container

@openshift-ci openshift-ci bot added size/m and removed size/m labels Jan 30, 2025
@openshift-ci openshift-ci bot added size/m and removed size/m labels Jan 30, 2025
@atheo89
Copy link
Member

atheo89 commented Jan 30, 2025

/lgtm

@jiridanek
Copy link
Member Author

/approve

Copy link
Contributor

openshift-ci bot commented Jan 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiridanek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jiridanek
Copy link
Member Author

This is taking too long and failing on infra. No point waiting

/override alles

This comment was marked as outdated.

@jiridanek
Copy link
Member Author

/override ci/prow/codeserver-notebook-e2e-tests ci/prow/images ci/prow/notebook-cuda-jupyter-ds-ubi9-python-3-11-pr-image-mirror ci/prow/notebook-cuda-jupyter-tf-ubi9-python-3-11-pr-image-mirror
ci/prow/notebook-cuda-rstudio-c9s-python-3-11-pr-image-mirror ci/prow/notebook-jupyter-datascience-ubi9-python-3-11-pr-image-mirror ci/prow/notebook-jupyter-datascience-ubi9-python-3-11-pr-image-mirror ci/prow/notebook-jupyter-pytorch-ubi9-python-3-11-pr-image-mirror ci/prow/notebook-jupyter-pytorch-ubi9-python-3-11-pr-image-mirror ci/prow/notebook-jupyter-trustyai-ubi9-python-3-11-pr-image-mirror ci/prow/notebooks-ubi9-e2e-tests ci/prow/rstudio-notebook-e2e-tests

Copy link
Contributor

openshift-ci bot commented Jan 30, 2025

@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/codeserver-notebook-e2e-tests, ci/prow/images, ci/prow/notebook-cuda-jupyter-ds-ubi9-python-3-11-pr-image-mirror, ci/prow/notebook-cuda-jupyter-tf-ubi9-python-3-11-pr-image-mirror

In response to this:

/override ci/prow/codeserver-notebook-e2e-tests ci/prow/images ci/prow/notebook-cuda-jupyter-ds-ubi9-python-3-11-pr-image-mirror ci/prow/notebook-cuda-jupyter-tf-ubi9-python-3-11-pr-image-mirror
ci/prow/notebook-cuda-rstudio-c9s-python-3-11-pr-image-mirror ci/prow/notebook-jupyter-datascience-ubi9-python-3-11-pr-image-mirror ci/prow/notebook-jupyter-datascience-ubi9-python-3-11-pr-image-mirror ci/prow/notebook-jupyter-pytorch-ubi9-python-3-11-pr-image-mirror ci/prow/notebook-jupyter-pytorch-ubi9-python-3-11-pr-image-mirror ci/prow/notebook-jupyter-trustyai-ubi9-python-3-11-pr-image-mirror ci/prow/notebooks-ubi9-e2e-tests ci/prow/rstudio-notebook-e2e-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jiridanek
Copy link
Member Author

/override ci/prow/codeserver-notebook-e2e-tests ci/prow/notebooks-ubi9-e2e-tests ci/prow/rstudio-notebook-e2e-tests

Copy link
Contributor

openshift-ci bot commented Jan 30, 2025

@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/codeserver-notebook-e2e-tests, ci/prow/notebooks-ubi9-e2e-tests, ci/prow/rstudio-notebook-e2e-tests

In response to this:

/override ci/prow/codeserver-notebook-e2e-tests ci/prow/notebooks-ubi9-e2e-tests ci/prow/rstudio-notebook-e2e-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jiridanek
Copy link
Member Author

/override ci/prow/notebook-jupyter-pytorch-ubi9-python-3-11-pr-image-mirror
ci/prow/notebook-jupyter-trustyai-ubi9-python-3-11-pr-image-mirror

Copy link
Contributor

openshift-ci bot commented Jan 30, 2025

@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/notebook-jupyter-pytorch-ubi9-python-3-11-pr-image-mirror

In response to this:

/override ci/prow/notebook-jupyter-pytorch-ubi9-python-3-11-pr-image-mirror
ci/prow/notebook-jupyter-trustyai-ubi9-python-3-11-pr-image-mirror

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jiridanek
Copy link
Member Author

/override ci/prow/notebook-jupyter-trustyai-ubi9-python-3-11-pr-image-mirror

Copy link
Contributor

openshift-ci bot commented Jan 30, 2025

@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/notebook-jupyter-trustyai-ubi9-python-3-11-pr-image-mirror

In response to this:

/override ci/prow/notebook-jupyter-trustyai-ubi9-python-3-11-pr-image-mirror

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants