-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHOAIENG-8388: rm(intel): Intel tensorflow notebook failed to get tested on OCP-CI so broken intel notebooks should be deleted #843
RHOAIENG-8388: rm(intel): Intel tensorflow notebook failed to get tested on OCP-CI so broken intel notebooks should be deleted #843
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
e287d86
to
dfb1524
Compare
Great idea to clean up the Intel-related items as well. |
IMO it's sufficient to keep them in the git repository history, but I'm not principally opposed to having 50k lines of dead code in the notebooks repo, if that's what other people prefer. |
+1 to clean everything up if keeping the files has no usage |
ok no objections by me |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed in Slack - I am going to get #834 ready for proper review today (January 17th).
If we merge #834 first and rebase this on top of it - that will at least have git
History be a little more functional/helpful should we need to resurrect the intel
stuff at some point in the future.
/lgtm |
will merge after @andyatmiami 's #834 gets in |
…ted on OCP-CI The Intel workbench images are broken in multiple ways and since we don't ship them, let's not even carry them on the books.
dfb1524
to
d45b345
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Reason for dismissing andyatmiami's review
/lgtm |
|
@jiridanek: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/override ci/prow/images |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jiridanek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/images, ci/prow/runtimes-ubi9-e2e-tests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
c5b27af
into
opendatahub-io:main
https://issues.redhat.com/browse/RHOAIENG-8388
Description
The Intel workbench images are broken in multiple ways and since we don't ship them, let's not even carry them on the books.
Follow-up to
How Has This Been Tested?
Merge criteria: