Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHOAIENG-8388: rm(intel): Intel tensorflow notebook failed to get tested on OCP-CI so broken intel notebooks should be deleted #843

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

jiridanek
Copy link
Member

@jiridanek jiridanek commented Jan 17, 2025

https://issues.redhat.com/browse/RHOAIENG-8388

Description

The Intel workbench images are broken in multiple ways and since we don't ship them, let's not even carry them on the books.

Follow-up to

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

This comment was marked as outdated.

@jiridanek jiridanek marked this pull request as ready for review January 17, 2025 06:55
@openshift-ci openshift-ci bot requested review from atheo89 and caponetto January 17, 2025 06:55
@atheo89
Copy link
Member

atheo89 commented Jan 17, 2025

Great idea to clean up the Intel-related items as well.
While reviewing this PR, I was thinking we could keep the intel dir and Dockerfiles but remove everything related to testing and building. WDYT?

@jiridanek
Copy link
Member Author

I was thinking we could keep the intel dir and Dockerfiles

IMO it's sufficient to keep them in the git repository history, but I'm not principally opposed to having 50k lines of dead code in the notebooks repo, if that's what other people prefer.

@caponetto
Copy link
Contributor

+1 to clean everything up if keeping the files has no usage

@atheo89
Copy link
Member

atheo89 commented Jan 17, 2025

ok no objections by me

@jiridanek jiridanek changed the title RHOAIENG-8388: rm(intel): Intel tensorflow notebook failed to get tested on OCP-CI RHOAIENG-8388: rm(intel): Intel tensorflow notebook failed to get tested on OCP-CI so broken intel notebooks should be deleted Jan 17, 2025
@caponetto
Copy link
Contributor

/lgtm

Copy link
Contributor

@andyatmiami andyatmiami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in Slack - I am going to get #834 ready for proper review today (January 17th).

If we merge #834 first and rebase this on top of it - that will at least have git History be a little more functional/helpful should we need to resurrect the intel stuff at some point in the future.

@atheo89
Copy link
Member

atheo89 commented Jan 20, 2025

/lgtm

@jiridanek
Copy link
Member Author

will merge after @andyatmiami 's #834 gets in

…ted on OCP-CI

The Intel workbench images are broken in multiple ways and since we don't ship them, let's not even carry them on the books.
@openshift-ci openshift-ci bot removed the lgtm label Jan 21, 2025
@jiridanek jiridanek added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jan 21, 2025
@jiridanek jiridanek requested a review from andyatmiami January 21, 2025 08:14
Copy link
Member

@atheo89 atheo89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 21, 2025
@jiridanek jiridanek dismissed andyatmiami’s stale review January 21, 2025 09:31

Reason for dismissing andyatmiami's review

@jstourac
Copy link
Member

/lgtm

@jiridanek
Copy link
Member Author

   34 | # define RCPP_VECTOR_PTR VECTOR_PTR_RO
      |                          ^~~~~~~~~~~~~
barrier.cpp:74:30: note: in expansion of macro ‘RCPP_VECTOR_PTR’
   74 |     return const_cast<SEXP*>(RCPP_VECTOR_PTR(x));                                                       // #nocov end
      |                              ^~~~~~~~~~~~~~~
make: *** [/usr/lib64/R/etc/Makeconf:204: barrier.o] Error 1
ERROR: compilation failed for package ‘Rcpp’
* removing ‘/opt/app-root/bin/Rpackages/4.4/Rcpp’
Warning message:
In i.p(...) :
  installation of package ‘/tmp/Rtmp83sENL/remotes165da333/Rcpp’ had non-zero exit status

expected ci fail in https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/opendatahub-io_notebooks/843/pull-ci-opendatahub-io-notebooks-main-runtimes-ubi9-e2e-tests/1881615007532191744

filled https://issues.redhat.com/browse/RHOAIENG-16384

Copy link
Contributor

openshift-ci bot commented Jan 21, 2025

@jiridanek: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/runtime-intel-ml-ubi9-python-3-11-pr-image-mirror dfb1524 link true /test runtime-intel-ml-ubi9-python-3-11-pr-image-mirror
ci/prow/runtime-intel-pyt-ubi9-python-3-11-pr-image-mirror dfb1524 link true /test runtime-intel-pyt-ubi9-python-3-11-pr-image-mirror
ci/prow/notebook-jupyter-intel-tf-ubi9-python-3-11-pr-image-mirror dfb1524 link true /test notebook-jupyter-intel-tf-ubi9-python-3-11-pr-image-mirror
ci/prow/runtime-intel-tf-ubi9-python-3-11-pr-image-mirror dfb1524 link true /test runtime-intel-tf-ubi9-python-3-11-pr-image-mirror
ci/prow/notebook-jupyter-intel-pyt-ubi9-python-3-11-pr-image-mirror dfb1524 link true /test notebook-jupyter-intel-pyt-ubi9-python-3-11-pr-image-mirror
ci/prow/notebook-jupyter-intel-ml-ubi9-python-3-11-pr-image-mirror dfb1524 link true /test notebook-jupyter-intel-ml-ubi9-python-3-11-pr-image-mirror
ci/prow/intel-notebooks-e2e-tests dfb1524 link true /test intel-notebooks-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jiridanek
Copy link
Member Author

/override ci/prow/images
/override ci/prow/runtimes-ubi9-e2e-tests
/approve

Copy link
Contributor

openshift-ci bot commented Jan 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiridanek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Jan 21, 2025

@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/images, ci/prow/runtimes-ubi9-e2e-tests

In response to this:

/override ci/prow/images
/override ci/prow/runtimes-ubi9-e2e-tests
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants