[v0.11] Changes to minimize exposure to security issues #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* cmd/agent/main.go
* Static code analysis states that unsanitized usage of the
`--component-port` flag can potentially lead to SSRF. In
practice, this may be very hard to happen, given that the source of
the flag is always an integer (taken from `containerPort` of a Pod).
Anyways, this is switching that flag to an Integer to be on the safe
side (and to prevent the warning from the static code analysis tool).
* python/kserve
* Run `poetry update`.
* The main reason of the upgrade is [a recent fix to the MSAL
library](AzureAD/microsoft-authentication-library-for-python@3427c25)
to escape an unsafe string.
* As an aside, this also moves away from
[CVE-202-4807](https://www.cve.org/CVERecord?id=CVE-2023-4807), which is
only applicable to Windows 64 platforms.
Additionally, this adds some more resiliency to openshift-ci runs.
Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com>
openshift-ci
bot
requested review from
anishasthana and
VedantMahabaleshwarkar
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: israel-hdez The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Merging, because #93 has been merged. |
israel-hdez
merged commit 1c21579
into
opendatahub-io:release-v0.11
39 of 42 checks passed
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #93, but for
release-v0.11branch (vX.Y branch).