[v0.11] Adapt qpext workflow for OpenDataHub #68
Conversation
Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: israel-hdez The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -5,6 +5,7 @@ on: | |||
| # Publish `master` as Docker `latest` image. | |||
| branches: | |||
| - master | |||
There was a problem hiding this comment.
is this still needed? This PR is for the release branch.
There was a problem hiding this comment.
It is not needed here. Although, I think, it also doesn't hurt.
If it is noisy, I can remove it.
| @@ -74,9 +76,14 @@ jobs: | |||
|
|
|||
| # Use Docker `latest` tag convention | |||
| [ "$VERSION" == "master" ] && VERSION=latest | |||
| [[ "$VERSION" =~ ^release- ]] && VERSION=$(echo $VERSION | sed 's/^release-//')-latest | |||
There was a problem hiding this comment.
so 0.11 release branch will use 0.11-latest ?
I think retag it to 2 tags: 0.11-$COMMIT_SHA and 0.11 . then quay.io will show these 2 images are the same.
WDYT?
There was a problem hiding this comment.
so 0.11 release branch will use 0.11-latest ?
Yes.
I think retag it to 2 tags: 0.11-$COMMIT_SHA and 0.11 . then quay.io will show these 2 images are the same.
Would it be useful? I don't see a reason for accumulating images.
There was a problem hiding this comment.
The image manifest on quay should include git ref if we don't include it in the image tag itself, but it's definitely easier for lookup purposes to do commit sha
There was a problem hiding this comment.
The image manifest on quay should include git ref if we don't include it in the image tag itself, but it's definitely easier for lookup purposes to do commit sha
The -latest suffix is the typical docker nomenclature. I'd think it maps "naturally". The v0.11-latest tag would map to release-v0.11 git ref.
If we strictly want a git-ref, I can create both the git-ref tag and the docker-friendly tag: release-v0.11 and v0.11-latest.
But, then, I'm still not sure about the tag carrying the SHA, as that would mean accumulating images.
There was a problem hiding this comment.
I'm still thinking on the tag with the SHA.
Do we really need it? Being ODH, I don't see a hard req for it.
|
/lgtm |
openshift-merge-robot
merged commit 61b4bc0
into
opendatahub-io:release-v0.11
update caikit-nlp package version
What this PR does / why we need it:
This adapts the Queue Proxy Extension Docker Publisher workflow to build an publish a container image to Quay.
Related #15
Feature/Issue validation/testing:
A test run can be found here: https://github.com/israel-hdez/kserve/actions/runs/5957673480
Release note: