Sync kserve/master into ODH/master #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* another squash Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com> * Add JobTTLSecondsAfterFinished option Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com> * Update config Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com> * Use labels to filter jobs instead of deleting old jobs Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com> * Add log in test Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com> * Fix test and helm chart Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com> * Create a seperate file system utils file Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com> * Add comments Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com> * Fix status update bug Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com> --------- Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com>
* Allow multiple node groups in the model cache CR Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com> * Fix test --------- Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com>
Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com>
* Clean up jobs Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com> * fix lint Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com> * Fix lint Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com> * Fix deletion propagation policy Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com> * Update test Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com> --------- Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com>
Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com>
* Add NodeGroup Name Into PVC Name Signed-off-by: Gavin Li <yli1109@bloomberg.net> * Add comment to fix multiple node group Signed-off-by: Dan Sun <dsun20@bloomberg.net> * fix openvino dependency Signed-off-by: Dan Sun <dsun20@bloomberg.net> --------- Signed-off-by: Gavin Li <yli1109@bloomberg.net> Signed-off-by: Dan Sun <dsun20@bloomberg.net> Co-authored-by: Dan Sun <dsun20@bloomberg.net>
* Make reconcilation configurable Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com> * Fix codegen Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com> * Remove a redudant space Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com> * Rename config Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com> * Fix lint Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com> --------- Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com> Co-authored-by: Dan Sun <dsun20@bloomberg.net>
Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> Co-authored-by: Dan Sun <dsun20@bloomberg.net>
… metrics bind port and address in helm chart (kserve#4127) Signed-off-by: Max Howell <maxhowell24@gmail.com> Co-authored-by: Dan Sun <dsun20@bloomberg.net>
* Fix EOF error Signed-off-by: Jonas Bruns <jonas.bruns@gmx.net> Signed-off-by: jonas <jonas.bruns@gmx.net> * fix error Signed-off-by: Jonas-Bruns <jonas.bruns@gmx.net> Signed-off-by: jonas <jonas.bruns@gmx.net> * rename error to ioErr Signed-off-by: Jonas-Bruns <jonas.bruns@gmx.net> Signed-off-by: jonas <jonas.bruns@gmx.net> * use errors.Is Signed-off-by: Jonas-Bruns <jonas.bruns@gmx.net> Signed-off-by: jonas <jonas.bruns@gmx.net> --------- Signed-off-by: Jonas Bruns <jonas.bruns@gmx.net> Signed-off-by: jonas <jonas.bruns@gmx.net> Signed-off-by: Jonas-Bruns <jonas.bruns@gmx.net> Co-authored-by: Dan Sun <dsun20@bloomberg.net>
|
/test e2e-slow |
… Mode Deployment chore: Follow up: remove the hardcoded clsuterIP setting and add the service configuration. Signed-off-by: Spolti <fspolti@redhat.com>
|
@spolti: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@spolti are the e2e tests still broken? PR seems fine to me, did some basic testing. |
4 tasks
israel-hdez
approved these changes
Jan 10, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: israel-hdez, spolti, VedantMahabaleshwarkar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Type of changes
Please delete options that are not relevant.
Feature/Issue validation/testing:
Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.
Test A
Test B
Logs
Special notes for your reviewer:
Checklist:
Release note:
Re-running failed tests
/rerun-all- rerun all failed workflows./rerun-workflow <workflow name>- rerun a specific failed workflow. Only one workflow name can be specified. Multiple /rerun-workflow commands are allowed per comment.