Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RHOAIENG-13089: Add global CM default values for the inference logger CA bundle #418

Open
wants to merge 1 commit into
base: release-v0.12.1
Choose a base branch
from
Open

RHOAIENG-13089: Add global CM default values for the inference logger CA bundle #418

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 19 additions & 3 deletions config/configmap/inferenceservice.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,10 @@ data:
"memoryLimit": "1Gi",
"cpuRequest": "100m",
"cpuLimit": "1",
"defaultUrl": "http://default-broker"
"defaultUrl": "http://default-broker",
"caBundle": "kserve-logger-ca-bundle",
"caCertFile": "service-ca.crt",
"tlsSkipVerify": false
Comment on lines +295 to +298
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure even though we accept this config, it will work or not because to support global cert from kserve, odh-model-controller overwrites this value with storage-config.

}
logger: |-
{
Expand All @@ -312,7 +315,17 @@ data:
"cpuLimit": "1",

# defaultUrl specifies the default logger url. If logger is not specified in the resource this url is used.
"defaultUrl": "http://default-broker"
"defaultUrl": "http://default-broker",

# caBundle specifies the name of the ConfigMap in the inference service's namespace containing the CA certificate to be used
"caBundle": "kserve-logger-ca-bundle",

# caCertFile specifies the entry in caBundle to be used as CA certificate
"caCertFile": "service-ca.crt",

# tlsSkipVerify specifies if the TLS verification should be skipped. Default, if missing, is "false"
"tlsSkipVerify": false

}

# ====================================== BATCHER CONFIGURATION ======================================
Expand Down Expand Up @@ -528,7 +541,10 @@ data:
"memoryLimit": "1Gi",
"cpuRequest": "100m",
"cpuLimit": "1",
"defaultUrl": "http://default-broker"
"defaultUrl": "http://default-broker",
"caBundle": "kserve-logger-ca-bundle",
"caCertFile": "service-ca.crt",
"tlsSkipVerify": false
}

batcher: |-
Expand Down
Loading