Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHOAIENG-12577] - enable modelCar by default #407

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

spolti
Copy link
Member

@spolti spolti commented Sep 13, 2024

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Type of changes
Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Feature/Issue validation/testing:

Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • Test A

  • Test B

  • Logs

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Checklist:

  • Have you added unit/e2e tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

Release note:


Re-running failed tests

  • /rerun-all - rerun all failed workflows.
  • /rerun-workflow <workflow name> - rerun a specific failed workflow. Only one workflow name can be specified. Multiple /rerun-workflow commands are allowed per comment.

Signed-off-by: Spolti <fspolti@redhat.com>
Copy link

@VedantMahabaleshwarkar VedantMahabaleshwarkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Sep 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spolti, VedantMahabaleshwarkar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [VedantMahabaleshwarkar,spolti]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spolti
Copy link
Member Author

spolti commented Sep 13, 2024

Validated with devFlag pointing to the PR,s branch:

    kserve:
      devFlags:
        manifests:
          - contextDir: config
            sourcePath: ''
            uri: 'https://github.com/spolti/kserve/tarball/RHOAIENG-12577'
Screenshot 2024-09-13 at 11 12 15

Copy link

openshift-ci bot commented Sep 13, 2024

@spolti: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-slow ecd2b86 link true /test e2e-slow
ci/prow/e2e-raw ecd2b86 link true /test e2e-raw

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@VedantMahabaleshwarkar VedantMahabaleshwarkar merged commit f69de18 into opendatahub-io:master Sep 13, 2024
21 of 25 checks passed
@spolti spolti deleted the RHOAIENG-12577 branch September 13, 2024 15:40
VedantMahabaleshwarkar pushed a commit to VedantMahabaleshwarkar/kserve that referenced this pull request Sep 13, 2024
VedantMahabaleshwarkar pushed a commit to VedantMahabaleshwarkar/kserve that referenced this pull request Sep 13, 2024
openshift-merge-bot bot pushed a commit that referenced this pull request Sep 13, 2024
Signed-off-by: Spolti <fspolti@redhat.com>
Co-authored-by: Filippe Spolti <fspolti@redhat.com>
VedantMahabaleshwarkar pushed a commit to VedantMahabaleshwarkar/kserve that referenced this pull request Sep 13, 2024
VedantMahabaleshwarkar pushed a commit to VedantMahabaleshwarkar/kserve that referenced this pull request Sep 13, 2024
VedantMahabaleshwarkar pushed a commit to VedantMahabaleshwarkar/kserve that referenced this pull request Sep 13, 2024
spolti referenced this pull request in spolti/kserve Sep 16, 2024
…outer-test-hermetic-poc

Red Hat Konflux update kserve-router-test-hermetic-poc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants