Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry-pick(#369) and fix conflict #370

Merged

Conversation

Jooho
Copy link

@Jooho Jooho commented Jun 6, 2024

cherry pick: #369

Signed-off-by: jooho lee <ljhiyh@gmail.com>
@Jooho
Copy link
Author

Jooho commented Jun 6, 2024

Do not merge this PR until other PRs are ready.

@Jooho Jooho mentioned this pull request Jun 6, 2024
@Jooho
Copy link
Author

Jooho commented Jun 6, 2024

/hold

@israel-hdez
Copy link

If this is just a cherry-pick, we should be able to merge this. Right?
IMO, it shouldn't have any unwanted effect regardless the other PRs aren't ready yet.

Copy link

@israel-hdez israel-hdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving my approval, in case you want to merge in advance:

/lgtm

Copy link

openshift-ci bot commented Jun 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: israel-hdez, Jooho, spolti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Jooho,israel-hdez,spolti]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spolti
Copy link
Member

spolti commented Jun 12, 2024

/lgtm

@Jooho
Copy link
Author

Jooho commented Jun 13, 2024

/unhold

@openshift-merge-bot openshift-merge-bot bot merged commit 9148a63 into opendatahub-io:release-v0.12.1 Jun 13, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants